Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links parens #1435

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Links parens #1435

merged 2 commits into from
Mar 8, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 6, 2019

Marked version: master

Markdown flavor: CommonMark

Description

fixes text in parenthesis after link being added as title.

marked demo
commonmark demo

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR)

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, a quick fixture.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@joshbruce joshbruce merged commit b5fb988 into markedjs:master Mar 8, 2019
@UziTech UziTech deleted the links-parens branch March 12, 2019 17:05
@styfle styfle mentioned this pull request Mar 25, 2019
12 tasks
@UziTech UziTech mentioned this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] We have to use '\' to add the '('
3 participants