Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing semicolons, add lint rule #1340

Merged
merged 3 commits into from
Sep 26, 2018
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 23, 2018

Marked version:

0.5.0

Markdown flavor: All

Description

There were several places missing semicolons which get auto-inserted but typically its better to be explicit and match the existing js style.

Functionally, there is no change.

https://lgtm.com/projects/g/markedjs/marked/alerts/?mode=list

Contributor

  • Test(s) exist to ensure functionality and minimize regression (lint rule)

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech
Copy link
Member

UziTech commented Sep 23, 2018

Perhaps we should add a rule to eslint to make sure we dont miss any in the future.

@styfle
Copy link
Member Author

styfle commented Sep 24, 2018

@UziTech Good point! I added a rule to .eslintrc.json 👍

@styfle styfle requested a review from UziTech September 24, 2018 01:02
Copy link
Contributor

@davisjam davisjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@styfle styfle changed the title Add missing semicolons Add missing semicolons, add lint rule Sep 26, 2018
@styfle styfle merged commit 99c8c1c into markedjs:master Sep 26, 2018
@styfle styfle deleted the semicolons branch September 26, 2018 15:27
@styfle styfle mentioned this pull request Nov 19, 2018
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants