Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.2 #1365

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Release v0.5.2 #1365

merged 1 commit into from
Nov 20, 2018

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 25, 2018

Publisher

  • $ npm version has been run.
  • Release notes in draft GitHub release are up to date
  • Release notes include which flavors and versions of Markdown are supported by this release
  • Committer checklist is complete.
  • Merge PR.
  • Publish GitHub release using master with correct version number.
  • $ npm publish has been run.
  • Create draft GitHub release to prepare next release.

Note: If merges to master occur after submitting this PR and before running $ npm pubish you should be able to

  1. pull from upstream/master (git pull upstream master) into the branch holding this version,
  2. run $ npm run build to regenerate the min file, and
  3. commit and push the updated changes.

Committer

In most cases, this should be someone different than the publisher.

  • Version in package.json has been updated (see PUBLISHING.md).
  • The marked.min.js has been updated; or,
  • release does not change library.
  • CI is green (no forced merge required).

@styfle
Copy link
Member Author

styfle commented Oct 25, 2018

Looks like jasmine broke compatibility with older versions of node recently.

I created a PR but I'm not sure many packages support Node < v4

jasmine/jasmine-npm#144

@UziTech
Copy link
Member

UziTech commented Oct 25, 2018

looks like tests are failing because Jasmine just released v3.3.0 which is not compatible with node v0.10

we could fix this by pinning our jasmine dev dependency to v3.2.0 or remove node v0.10 from travis

@UziTech
Copy link
Member

UziTech commented Oct 25, 2018

to be honest if any of our dependents are still using node v0.10 they are probably the ones pinning their marked dependency to 0.3.6

@UziTech
Copy link
Member

UziTech commented Oct 25, 2018

according to https://libraries.io/npm/marked/usage we have less than 400 dependents using >=0.5.0

and ~1000 using >=0.4.0

@styfle
Copy link
Member Author

styfle commented Nov 19, 2018

Release Notes

Bug Fixes

Other

Copy link
Member

@joshbruce joshbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do eet!

@styfle styfle merged commit 97be813 into markedjs:master Nov 20, 2018
@styfle styfle deleted the release-0-5-2 branch November 20, 2018 00:03
@styfle
Copy link
Member Author

styfle commented Nov 20, 2018

Boom 💣

https://www.npmjs.com/package/marked/v/0.5.2

zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants