-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo Page: Give user feedback when "options" is not valid JSON. #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change in the CSS snuck in from a previous iteration of the demo page options UI. Remove it.
styfle
approved these changes
Oct 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🎉
UziTech
approved these changes
Oct 19, 2018
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version:
Commit: da9d155
Markdown flavor: all
Description
When the "options" object provided by users doesn't parse, make the input field red to let them know:
And when it does parse, return to a regular old textarea.
Expectation
Some kind of visual indication that the options entered into the text box aren't valid.
Result
No such indication.
What was attempted
https://marked.js.org/demo/?text=%23%23%23%20These%20options%20don%27t%20work.&options=a
Contributor
Committer
In most cases, this should be a different person than the contributor.