Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Image Replace menu option #154

Closed
markummitchell opened this issue Jun 30, 2016 · 17 comments
Closed

Import Image Replace menu option #154

markummitchell opened this issue Jun 30, 2016 · 17 comments

Comments

@markummitchell
Copy link
Owner

Add menu option for keeping the current document but replacing the image in the background. This can be useful when working on many images that all have the same, or almost the same, settings.

@crayxt
Copy link
Collaborator

crayxt commented Jun 30, 2016

When imported, new image is placed in front, and axes/curves are invisible behind the new image.

@crayxt
Copy link
Collaborator

crayxt commented Jun 30, 2016

Is there any option to adjust imported image to match existing axes?

@markummitchell
Copy link
Owner Author

In linux the new image is correctly placed, and I do not have windows running yet for testing. However, I checked in a possible fix.

There is no option to automatically adjust axes. That would be a major upgrade.

@crayxt
Copy link
Collaborator

crayxt commented Jun 30, 2016

I'll test as soon as appveyor build is ready. By the way, what is your plan to move windows releases to MSVC?

@crayxt
Copy link
Collaborator

crayxt commented Jun 30, 2016

Nope, still the same.

@markummitchell
Copy link
Owner Author

I am using the same steps as in the appveyor script, with the same compiler. I am not familiar with the 'ps:gc' step though. But the script and pre-built libraries are excellent and have saved days of work

@crayxt
Copy link
Collaborator

crayxt commented Jun 30, 2016

@markummitchell 'ps:gc' is a powershelll equivalent of sed

@crayxt
Copy link
Collaborator

crayxt commented Jun 30, 2016

@markummitchell By saying that 'axes/curves are invisible behind the new image` I meant that points of axes/curves are visible, but there are no connection lines between them.

markummitchell pushed a commit that referenced this issue Jul 7, 2016
@markummitchell
Copy link
Owner Author

I am not able to reproduce the problem in either Windows or Linux, using the following steps: 1) Import image_replace_1.png 2) Create 3 axis points 3) Create points along the curve 4) Import (Image Replace) with image_replace_2.png. The curves and points all appear in front of the background as expected. Are you doing something different?

@crayxt
Copy link
Collaborator

crayxt commented Jul 7, 2016

@markummitchell I was using example dig file from #137
After loading, I replaced its background with standard image from Windows Pictures folder

@markummitchell
Copy link
Owner Author

The line colors in the dig file from #137 are Transparent.

@crayxt
Copy link
Collaborator

crayxt commented Jul 7, 2016

@markummitchell Ok, I confirm that setting a color for a curve helped. But why it is not possible to make Axe non-transparent?

@markummitchell
Copy link
Owner Author

markummitchell commented Jul 7, 2016

The transparent curve for the Axes was meant to be more simple for users. Since 2 of the 3 points often have the same X value, any Axes curve would have to be drawn as a Relation, which could be confusing for those who only see/understand Functions in Engauge. Specifically, a Relation curve through axes points would be smooth (using existing code) resulting in a unfamiliar "rounded L" shape. Also, the Axes Checker highlights the axes points, so adding a curve to make them visible is less critical.

@crayxt
Copy link
Collaborator

crayxt commented Jul 8, 2016

Do we have an option to fine position imported replacement image? To match axes points, at least

@markummitchell
Copy link
Owner Author

Engauge only has manual adjustment, but that should only take a few seconds for good accuracy, and a few more seconds for excellent accuracy.

@k1moradi
Copy link

Importing and replacing a new image, Engauge askes me for a new file name on save command, which is annoying. If someone wants to make a new file, they can choose one of the other import options.

@markummitchell
Copy link
Owner Author

The last post is now issue #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants