Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/replace triggers Save As #332

Closed
markummitchell opened this issue May 29, 2019 · 6 comments
Closed

Import/replace triggers Save As #332

markummitchell opened this issue May 29, 2019 · 6 comments

Comments

@markummitchell
Copy link
Owner

It would be more convenient if import/replace of the image did not automatically trigger Save As but instead allowed Save.

Currently, this enhancement could cause loss of data if the currently opened file was not already given a unique name before the import/replace. However, this is easily solved by adding a new setting that could allow Save immediately after the import/replace. The default would offer the current behavior which tries to reduce the chances of loss of data.

@markummitchell
Copy link
Owner Author

@k1moradi I am trying to understand the scenario. Can you describe the steps you are doing and what steps you would prefer?

@k1moradi
Copy link

k1moradi commented Jun 3, 2019

I think import (image replace) function should allow saving the file instead of "save as". Two possible solutions come to my mind.
(1) Keeping the current behavior (opening save as menu) but suggesting the existing file name and path on save.
(2) After the successful import of new image opening a popup menu to ask the users if they want to "save as" or save.

@markummitchell
Copy link
Owner Author

markummitchell commented Jun 5, 2019

I think I understand. Can you try out the Windows 64 bit pre-release at https://ci.appveyor.com/project/markummitchell/engauge-digitizer/branch/master/job/osbbj6wprbju66eh/artifacts? I want to make this will solve the problem. There is also a 32 bit pre-release at https://ci.appveyor.com/project/markummitchell/engauge-digitizer/branch/master/job/yl92yi05eaq35rr8/artifacts. They use option #1 above, along with a new 'Image replace renames document' flag in the Main Windows settings.

@k1moradi
Copy link

k1moradi commented Jun 5, 2019

So, I tried both 32 and 64-bit builds. I opened a dig file and import (replaced) the image (no message box appeared), then I pressed the save. The program opened the save as menu suggesting the name of the new image file without remembering the original path. So I can say no it did not work because the program neither remembered the original dig file name nor the path it was saved already.

@markummitchell
Copy link
Owner Author

markummitchell commented Jun 5, 2019

The default is the old behavior. You will need to change Image Replace Renames Document in Main Window settings

@k1moradi
Copy link

k1moradi commented Jun 5, 2019

I see now. Thank you. I confirm it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants