Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set key prop on CheckboxGroupInputItem #3536

Merged
merged 3 commits into from
Aug 19, 2019
Merged

Set key prop on CheckboxGroupInputItem #3536

merged 3 commits into from
Aug 19, 2019

Conversation

jaytula
Copy link
Contributor

@jaytula jaytula commented Aug 18, 2019

The key prop is missing in the mapping to CheckboxGroupInputItem in choices.map. This results in console.warn. This can be seen in the JavaScript console of simple example app after clicking the Edit on any of the Posts.

Warning: Each child in a list should have a unique "key" prop.

Check the render method of `CheckboxGroupInput`. See https://fb.me/react-warning-keys for more information.
    in CheckboxGroupInputItem (created by CheckboxGroupInput)
    in CheckboxGroupInput (created by PostEdit)
    in div (created by FormInput)
    in FormInput (created by WithStyles(FormInput))
    in WithStyles(FormInput) (created by FormTab)
    in span (created by FormTab)

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks :)

@djhi djhi added this to the 3.0.0 milestone Aug 19, 2019
@djhi djhi merged commit a893009 into marmelab:next Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants