Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set key prop on CheckboxGroupInputItem #3536

Merged
merged 3 commits into from
Aug 19, 2019
Merged

Set key prop on CheckboxGroupInputItem #3536

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c319828
Set mapping key prop on CheckboxGroupInputItem
jaytula Aug 18, 2019
16c9f58
Use lodash get to handle cases where optionValue is not id
jaytula Aug 18, 2019
c804c2e
CheckboxGroupInputItem choice prop expects choice object
jaytula Aug 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/ra-ui-materialui/src/input/CheckboxGroupInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React, { useCallback, FunctionComponent } from 'react';
import PropTypes from 'prop-types';
import get from 'lodash/get';
import FormLabel from '@material-ui/core/FormLabel';
import FormControl, { FormControlProps } from '@material-ui/core/FormControl';
import FormGroup from '@material-ui/core/FormGroup';
Expand Down Expand Up @@ -161,6 +162,7 @@ const CheckboxGroupInput: FunctionComponent<
<FormGroup row>
{choices.map(choice => (
<CheckboxGroupInputItem
key={get(choice, optionValue)}
choice={choice}
id={id}
onChange={handleCheck}
Expand Down