Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pagination on bulk delete #4894

Merged
merged 21 commits into from
Jul 24, 2020
Merged

Fix pagination on bulk delete #4894

merged 21 commits into from
Jul 24, 2020

Conversation

JulienMattiussi
Copy link
Contributor

@JulienMattiussi JulienMattiussi commented Jun 4, 2020 •
edited
Loading

Closes #4794

Issue 1 :

Fix MUI warning when deleting last items of last page by skipping the rendering before fallback to the previous page.

image

Issue 2 :

Avoid List to always fallback on Page 1 when bulk-deleting some items.

Fallback1

@JulienMattiussi JulienMattiussi added RFR Ready For Review WIP Work In Progress and removed WIP Work In Progress labels Jun 4, 2020
@Luwangel
Copy link
Contributor

Luwangel commented Jul 7, 2020

Hi! You have a merge conflict. Could you rebase it?

JulienMattiussi and others added 15 commits July 23, 2020 14:13
@JulienMattiussi @Luwangel
Fix pagination on bulk delete
070de12
@JulienMattiussi @Luwangel
fix tests
8fcdfe8
@JulienMattiussi @Luwangel
fix unit tests
3d2b2ef
@JulienMattiussi @Luwangel
little fixes on review
e70acd6
@JulienMattiussi @Luwangel
refactor test (review)
809f669
@Luwangel
Use a useMemo instead of a useCallback to compute the nb of pages in …
76740a5 
…Pagination
@Luwangel
Fix the getNumberOrDefault method that returns the default value inst…
3637749 
…ead of 0 when parsing "0"
@Luwangel
Compute the total pages for a list and pass it to the list context
e6357bc
@Luwangel
Set the page to the last existing page in the useListController if qu…
0774a43 
…erying a page out of bounds
@Luwangel
Use totalPages in Pagination
8850de6
@Luwangel
Remove console.log
fa8ec88
@Luwangel
Sanitize the total pages prop in the ListView
e3c9cf4
@Luwangel
Fix total page out of bound limit for material ui in Pagination
f08f96f
@Luwangel
Fix a problem with Pagination when trying to pass negative pages thro…
9e499ad 
…ugh the URL
@Luwangel
Write a new test for negative pages
956f627
@Luwangel Luwangel modified the milestones: 3.8.0, 3.7.2 Jul 24, 2020
@JulienMattiussi JulienMattiussi merged commit f20546c into master Jul 24, 2020
@JulienMattiussi JulienMattiussi deleted the fix-pagination-on-delete branch July 24, 2020 16:01
@alanpoulain alanpoulain mentioned this pull request May 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto requested changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.

warning when deleting last element on last page in data table
3 participants
@JulienMattiussi @Luwangel @fzaninotto