Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pagination on bulk delete #4894

Merged
merged 21 commits into from
Jul 24, 2020
Merged

Fix pagination on bulk delete #4894

merged 21 commits into from
Jul 24, 2020

Commits on Jul 23, 2020

  1. Fix pagination on bulk delete

    @JulienMattiussi @Luwangel
    JulienMattiussi authored and Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    070de12 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @JulienMattiussi @Luwangel
    JulienMattiussi authored and Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    8fcdfe8 View commit details
    Browse the repository at this point in the history

  3. fix unit tests

    @JulienMattiussi @Luwangel
    JulienMattiussi authored and Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    3d2b2ef View commit details
    Browse the repository at this point in the history

  4. little fixes on review

    @JulienMattiussi @Luwangel
    JulienMattiussi authored and Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    e70acd6 View commit details
    Browse the repository at this point in the history

  5. refactor test (review)

    @JulienMattiussi @Luwangel
    JulienMattiussi authored and Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    809f669 View commit details
    Browse the repository at this point in the history

  6. Use a useMemo instead of a useCallback to compute the nb of pages in … 

    …Pagination
    @Luwangel
    Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    76740a5 View commit details
    Browse the repository at this point in the history

  7. Fix the getNumberOrDefault method that returns the default value inst… 

    …ead of 0 when parsing "0"
    @Luwangel
    Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    3637749 View commit details
    Browse the repository at this point in the history

  8. Compute the total pages for a list and pass it to the list context

    @Luwangel
    Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    e6357bc View commit details
    Browse the repository at this point in the history

  9. Set the page to the last existing page in the useListController if qu… 

    …erying a page out of bounds
    @Luwangel
    Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    0774a43 View commit details
    Browse the repository at this point in the history

  10. Use totalPages in Pagination

    @Luwangel
    Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    8850de6 View commit details
    Browse the repository at this point in the history

  11. Remove console.log

    @Luwangel
    Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    fa8ec88 View commit details
    Browse the repository at this point in the history

  12. Sanitize the total pages prop in the ListView

    @Luwangel
    Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    e3c9cf4 View commit details
    Browse the repository at this point in the history

  13. Fix total page out of bound limit for material ui in Pagination

    @Luwangel
    Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    f08f96f View commit details
    Browse the repository at this point in the history

  14. Fix a problem with Pagination when trying to pass negative pages thro… 

    …ugh the URL
    @Luwangel
    Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    9e499ad View commit details
    Browse the repository at this point in the history

  15. Write a new test for negative pages

    @Luwangel
    Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    956f627 View commit details
    Browse the repository at this point in the history

  16. Fix the ListControllerProps TypeScript type

    @Luwangel
    Luwangel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    3d33bfb View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. Make the total pages optionnal in TypeScript types

    @Luwangel
    Luwangel committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    446ed85 View commit details
    Browse the repository at this point in the history

  2. Count the total pages everywhere and not make it optional

    @Luwangel
    Luwangel committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    8116dbb View commit details
    Browse the repository at this point in the history

  3. Remove the totalPages from contexts because it could be recomputed us… 

    …ing perPage and total
    @Luwangel
    Luwangel committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    7c75b30 View commit details
    Browse the repository at this point in the history

  4. Apply reviews

    @Luwangel
    Luwangel committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    6e46f41 View commit details
    Browse the repository at this point in the history

  5. Fix useEffect in useListController

    @Luwangel
    Luwangel committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    8223ab0 View commit details
    Browse the repository at this point in the history