Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OS-designated ports instead of random ports to create sub pools #3053

Merged
merged 12 commits into from
May 25, 2022
Merged

Use OS-designated ports instead of random ports to create sub pools #3053

merged 12 commits into from
May 25, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented May 19, 2022 •
edited
Loading

What do these changes do?

It is often hard to obtain free ports, esp. in containers with host ports. It is better to assign ports of sub-pools by OS itself.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: enhancement request mod: actor to be backported Indicate that the PR need to be backported to stable branch labels May 19, 2022
@wjsi wjsi added this to the v0.10.0a1 milestone May 19, 2022
@wjsi wjsi requested a review from a team as a code owner May 19, 2022 11:32
@wjsi wjsi force-pushed the enh/sys_port branch 11 times, most recently from 2445907 to e26a067 Compare May 20, 2022 14:35
@wjsi wjsi marked this pull request as draft May 20, 2022 15:41
@wjsi wjsi force-pushed the enh/sys_port branch 2 times, most recently from 8d9722c to 592e8a7 Compare May 23, 2022 07:30
@wjsi wjsi marked this pull request as ready for review May 23, 2022 09:59
@wjsi wjsi marked this pull request as draft May 23, 2022 16:42
@wjsi wjsi force-pushed the enh/sys_port branch 4 times, most recently from b6847d6 to a46e9f0 Compare May 24, 2022 07:27
@wjsi wjsi marked this pull request as ready for review May 24, 2022 09:15
qinxuye
qinxuye approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, about router.set_instance(None), another PR can be raised.

mars/conftest.py

mars.stop_server()
mars.stop_server()
Router.set_instance(None)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about including cleaning router into stop server?

hekaisheng
hekaisheng approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 4cd4eb1 into mars-project:master May 25, 2022
@wjsi wjsi deleted the enh/sys_port branch May 25, 2022 04:17
wjsi added a commit to wjsi/mars that referenced this pull request May 25, 2022
@wjsi
Use OS-designated ports instead of random ports to create sub pools (m…
7f9e40a 
…ars-project#3053)
@wjsi wjsi mentioned this pull request May 25, 2022
Merged
wjsi added a commit that referenced this pull request May 25, 2022
@wjsi
[BACKPORT] Use OS-designated ports instead of random ports to create …
4852097 
…sub pools (#3053) (#3087)
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekaisheng hekaisheng hekaisheng approved these changes

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: actor type: enhancement request
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.
3 participants
@wjsi @qinxuye @hekaisheng