Complete vala parser #6
Conversation
albfan
commented
Dec 8, 2019
•
albfan
commented
- Added test suite
- Added keywords
- Avoid set statements (if, while, for) as methods
- Added namespace parsing
- Complete copyright
- Fix code details (typos, parser order)
if, while, for shouldn't be detected as methods
|
If changes make sense, would be great to rebase on top of upstream master. |
df92d33e Merge pull request universal-ctags#14 from masatake/delete-unused-variable ca2c510a Remove an unused constant fbd32ce5 Specify -Wall 032c361f Merge pull request universal-ctags#9 from masatake/add-function-for-accessing-pseudo-tags 02ef33e0 gitignore: simplified b5acda83 tests: add a case for tagsFirstPseudoTag() and tagsNextPseudoTag() d0a854be tagsFirstPseudoTag,tagsNextPseudoTag: add functions to access pseudo tags bc8f7b8e refactor: introduce findNextFull(), customizable version of findNext() 19e8dca2 refactor: introduce findSequentialFull(), customizable version of findSequential() 28e0767e refactor: introduce a predicate function for testing a line starting with "!_" e56b7dc4 Merge pull request universal-ctags#8 from masatake/fix-buildsys-for-make-distcheck d1146037 circleci: run "make distcheck" on fedora31 1c96f500 tests: change the directory where input files exist 3d05b544 tests: update a comment f0a48a6f tests: fix the name of a test input file a295cb57 tests: fix the path for header inclusion 238d1800 Merge pull request universal-ctags#7 from masatake/pkg-config-file 748082c3 Merge pull request #6 from masatake/add-test-case-for-tagsFind 5295186e Fix the library description in .pc file dbca5137 tests: add a case for testing tagsFind and tagsFindNext 2d8edf50 tests: update comments b9ac2209 Merge pull request #5 from masatake/revise-tagsOpen 1f9a1ab3 tests: verify the behavior of tagsOpen() when tagFileInfo is NULL d53217f0 tagsOpen: revise the implementation 6d051772 Add .circleci/config.yml fafecf2a Implement "make check" 13b252fe cosmetic: delete empty lines git-subtree-dir: libreadtags git-subtree-split: df92d33eb312db710b995a75e21cff3f0e4efa0e
|
Hey, any progress on this? I'm a recent convert to Vala looking for a bit more tools support…! |
|
No progress. You can finish the work. |
|
Thanks, what's left to do? |
I'm sorry but I don't know. |
|
I read the discussions, and nothing seemed to be left to do. I rebased https://github.com/albfan/ctags/tree/vala on master, and got it to build (there was just one call in ctags that had been renamed since the branch was last updated: The test pass. I ran it on a Vala project, and it looks good. I saw that you wanted the commits for Vala squashed, so I squashed it down to two commits: one for your initial work, and one for Alberto's, with my very minor fix at the end. |
|
Could you open a pull request at https://github.com/universal-ctags/ctags/pulls ? I will review it. |
|
Thanks, I've opened a pull request. I found a bug (rather, something missing) and added a test. I kept my work in separate commits so it's easier to review, but of course I can squash them down for merging. |
|
Great so I found universal-ctags#2677 and seems to work. I probably can contribute there as plumbings are ready |
