-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vala parser (in progress) #2677
base: master
Are you sure you want to change the base?
Conversation
masatake
commented
Oct 25, 2020
•
edited
Loading
edited
- https://www.vala-project.org/doc/vala/
- https://www.vala-project.org/doc/manual.pdf
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2677 +/- ##
==========================================
+ Coverage 85.02% 85.10% +0.07%
==========================================
Files 228 229 +1
Lines 53901 54345 +444
==========================================
+ Hits 45832 46252 +420
- Misses 8069 8093 +24 ☔ View full report in Codecov by Sentry. |
@rrthomas, I need your help.
For I tried anjuta-tags installed via Fedora's repository. However, it seems that it has no Vala parser. The kinds set of the vala parser we are working on is based on anjuta-tags.
I cannot find variable kind. Should I add variable kind? or should I use the "field" kind instead? |
In this test case, main is tagged as a method. |
@masatake: Your analysis sounds right: it looks like it's a field. |
|
@rrthomas, thank you.
It is the reason why anjuta-tags emits nothing for |
Sorry, I'm not sure what you're referring to. Is
I don't think so, I think |
input.vala is u-ctags terminology. It means any input file written in Vala.
I can't find "Vala" in "anjuta-tags --list-languages| grep -i vala". |
Ah, thanks for explaining.
Looks like it. |
I'm just using this building as:
Will provide feedback but looks to parse almost everything. Any known blocker to merge? I think I can contribute again if needed |
Thank you, but I cannot remember why I didn't merge this. I read test cases to find the incompleteness of the parser. A. typeref fields for methods should be filled.
The tag entry for the
The return type B. Semantics?
For X.MyObject, which tags should we make "X.MyObject" or "MyObjecRegardingr as reading a test case (qnamed-class.d), I expected ctags makes a tag for "X.MyObject". C. kinds having only stubs D. Generics and other language features B. is the primary blocker. Maybe we should make a reference tag for This "indirection through a reference tag" technique is nice because it is possible to make a tag for It seems in the year 2020, I didn't get the idea. |
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Fix a misleading comment. Fix incorrect spacing of close brace. Remove unnecessary conversion to bool. Add an “else” before a mutually-exclusive “if”.
Attributes, in matched square brackets, should be ignored, as otherwise they upset parsing. Add a test.
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Amazing work, @masatake! |
I added lines to parseClassBody. However, it seems that I should add them to recurseValaTags. I have to restart from 8e16ea9. I extended the test cases that valac accepted. So restarting is not so hard. |