-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix security audit - get rid of chrono and use time directly #2376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the clippy warning left to fix and LGTM
By the way if you have an idea to better implement days_hours_mins_secs
Good catch ! Fixed ! Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I'm wondering why there is an unwrap in to_utc_string but eh
bors merge |
Build succeeded: |
Chrono still use a very old version of time (0.1 now it's 0.3). They have a PR running since months for updating but it seems that there is communication problems that lead to long time development. The PR : chronotope/chrono#639
This break our CI like a lot of others projects that use
cargo audit
. A lot of projects that use chrono to do things that are now implemented in the new version oftime
has switched to usetime
directly instead of using tokio. Some examples :So as we also only use chrono to make things that now possible in
time
which is more maintained I suggest in this PR a change to usetime
instead ofchrono
. So that it will fix our CI and make us use a more maintained dependency.Fix #2374