This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Get rid of chrono in favor of time #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
approved these changes
Feb 15, 2022
bors bot
added a commit
to massalabs/massa
that referenced
this pull request
Mar 8, 2022
2376: Fix security audit - get rid of chrono and use time directly r=AurelienFT a=AurelienFT Chrono still use a very old version of time (0.1 now it's 0.3). They have a PR running since months for updating but it seems that there is communication problems that lead to long time development. The PR : chronotope/chrono#639 This break our CI like a lot of others projects that use `cargo audit`. A lot of projects that use chrono to do things that are now implemented in the new version of `time` has switched to use `time` directly instead of using tokio. Some examples : - brave/brave-browser#20568 - meilisearch/milli#450 So as we also only use chrono to make things that now possible in `time` which is more maintained I suggest in this PR a change to use `time` instead of `chrono`. So that it will fix our CI and make us use a more maintained dependency. Fix #2374 Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use
chronoas a wrapper aroundtime, and since there has been an open CVE onchronofor at least 3 months now and the repo seems to be struggling with maintenance, I think we should usetimedirectly which is way more active and sufficient for our use case.EDIT: Actually the CVE status has been known for more than 6 months: chronotope/chrono#602