Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-31793 Header alerts #1884

Merged
merged 12 commits into from
Mar 4, 2024
Merged

Conversation

ygannett
Copy link
Contributor

@ygannett ygannett commented Feb 26, 2024

Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions

Description

  • Add a border to the alert header button
  • Change the border for alert item container to match the styles to the header button
  • Change the icon for notice (yellow one) in alert items

Related Issue / Ticket

Steps to Test

  1. Go to the park location page or header alert component.
  2. Find the component has a gray border.
  3. Find the border doesn't add up (= get thicker) when it has multiple alert items.
  4. The icon for the notice is charged to the bell and it's green.

Screenshots

Use something like licecap to capture gifs to demonstrate behaviors.

Additional Notes:

Anything else to add?

Impacted Areas in Application

@todo

Today I learned...

@ygannett
Copy link
Contributor Author

The Backstop failures are from map renddering.

@clairesunstudio clairesunstudio merged commit 833f5ed into develop Mar 4, 2024
5 checks passed
@clairesunstudio clairesunstudio deleted the patternlab/DP-31793_header-alerts branch March 4, 2024 15:03
@clairesunstudio clairesunstudio mentioned this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants