Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DP-31793 Header alerts #1884

Merged
merged 12 commits into from
Mar 4, 2024
Merged

DP-31793 Header alerts #1884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0c12334
make header alert border darker
ygannett Feb 26, 2024
9136673
change icon for notice in header alert
ygannett Feb 26, 2024
d757b76
change border width from 2px to 1px
ygannett Feb 26, 2024
4e8e2f2
update Backstop reference screenshots
ygannett Feb 26, 2024
f705f37
add changelog for DP-31793
ygannett Feb 26, 2024
030b149
Merge branch 'develop' into patternlab/DP-31793_header-alerts
clairesunstudio Feb 28, 2024
5b8034a
Merge branch 'develop' into patternlab/DP-31793_header-alerts
clairesunstudio Mar 1, 2024
9db905b
Update changelogs/DP-31793.yml
clairesunstudio Mar 1, 2024
2387970
Merge branch 'develop' into patternlab/DP-31793_header-alerts
clairesunstudio Mar 1, 2024
7215403
Merge branch 'develop' into patternlab/DP-31793_header-alerts
clairesunstudio Mar 4, 2024
4b8c746
swap all yellow input warning icons in header alerts
clairesunstudio Mar 4, 2024
7865cc5
approve backstop
clairesunstudio Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelogs/DP-31793.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Changed:
- project: Patternlab
component: HeaderAlerts
description: Add border for the component and chnage icon for notice to improve the color contrasts. (#1884)
issue: DP-31793
impact: Patch
6 changes: 4 additions & 2 deletions packages/assets/scss/03-organisms/_header-alerts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

color: $c-gray-darkest;
margin-bottom: 0;
border: 1px solid $c-bd-divider-dark;

&__button {
color: $c-gray-darkest;
Expand Down Expand Up @@ -83,9 +84,10 @@

.ma__action-step {

border-color: $c-bd-divider;
border-width: 2px;
border-color: $c-bd-divider-dark;
border-width: 1px;
border-style: solid;
border-top: 0;

&__header {
color: $c-gray-darkest;
Expand Down
Binary file modified ...ckstopjs/reference/regression_page_location-park-content_0_document_0_phone.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...kstopjs/reference/regression_page_location-park-content_0_document_1_tablet.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../reference/regression_template_01-content-types-location_0_document_0_phone.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...reference/regression_template_01-content-types-location_0_document_1_tablet.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/patternlab/styleguide/source/_patterns/03-organisms/by-template/header-alerts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
{
"accordion": true,
"isExpanded": false,
"icon": "input-warning",
"icon": "alert",
"iconLabel": "notice",
"level": "3",
"title": "Actualizaciones sobre el desempleo",
Expand Down Expand Up @@ -72,7 +72,7 @@
"suffix": "Updated: Mar. 23rd, 2021, 9:50 am"
},
{
"icon": "input-warning",
"icon": "alert",
"iconLabel": "notice",
"level": "3",
"title": "Actualizaciones sobre el desempleo",
Expand Down
2 changes: 1 addition & 1 deletion packages/patternlab/styleguide/source/_patterns/04-templates/01-content-types/location.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"accordion": true,
"isExpanded": false,
"accordionLabel": "Expand Actualizaciones sobre el desempleo",
"icon": "input-warning",
"icon": "alert",
"title": "Actualizaciones sobre el desempleo",
"suffix": "Updated: Mar. 17th, 2021, 11:10 am",
"richText": {
Expand Down
2 changes: 1 addition & 1 deletion packages/patternlab/styleguide/source/_patterns/05-pages/location-park-content.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"accordion": true,
"isExpanded": false,
"accordionLabel": "Expand Actualizaciones sobre el desempleo",
"icon": "input-warning",
"icon": "alert",
"title": "Actualizaciones sobre el desempleo",
"suffix": "Updated: Mar. 17th, 2021, 11:10 am",
"richText": {
Expand Down
2 changes: 1 addition & 1 deletion packages/patternlab/styleguide/source/assets/data/header-alerts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"accordion": true,
"isExpanded": false,
"accordionLabel": "Expand Actualizaciones sobre el desempleo",
"icon": "input-warning",
"icon": "alert",
"title": "Actualizaciones sobre el desempleo",
"suffix": "Updated: Mar. 17th, 2021, 11:10 am",
"richText": {
Expand Down