implemented methods dedicated to user logging in #1145
Conversation
| @@ -11,6 +13,11 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService userService = new UserService(); | |||
There was a problem hiding this comment.
let's make UserService class-level variable to avoid creating this object each time you call login method
There was a problem hiding this comment.
Ok. I thought that since Java take care of automatically destruction of object (because it doesn't have explicitly defined destructors) - it would be right to create this object inside of method, just to renew users datarecords each time when method is called. Second reason - what will happen if between method calls to the User will be added new authentication records...
| @@ -11,6 +13,11 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService userService = new UserService(); | |||
| User user = userService.findByEmail(email); | |||
| if (user != null) { | |||
There was a problem hiding this comment.
you can use ternary operator here
There was a problem hiding this comment.
i tried something like this
return (this.userService.findByEmail(email) != null) ? this.userService.findByEmail(email).getPassword().equals(password) : false;
but stylecheck scolded me because of to long code line (((
… in login method use ternary operator
now userService object is the class-level variable and password check in login method use ternary operator