Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented methods dedicated to user logging in #1145

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

implemented methods dedicated to user logging in #1145

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89231d6
implemented methods dedicated to user logging in
gekatonheyr Dec 7, 2024
ffc6cba
implemented methods dedicated to user logging in
gekatonheyr Dec 7, 2024
cded22b
have made UserService class-level variable
gekatonheyr Dec 7, 2024
cc72766
have made UserService class-level variable
gekatonheyr Dec 7, 2024
b6b40cd
now userService object is the class-level variable and password check…
gekatonheyr Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/mate/academy/service/AuthenticationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package mate.academy.service;

import mate.academy.model.User;

public class AuthenticationService {
/**
* Imagine that some user wants to login to your site.
Expand All @@ -11,6 +13,11 @@ public class AuthenticationService {
* Return false in any other cases.
*/
public boolean login(String email, String password) {
UserService userService = new UserService();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make UserService class-level variable to avoid creating this object each time you call login method

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I thought that since Java take care of automatically destruction of object (because it doesn't have explicitly defined destructors) - it would be right to create this object inside of method, just to renew users datarecords each time when method is called. Second reason - what will happen if between method calls to the User will be added new authentication records...

User user = userService.findByEmail(email);
if (user != null) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use ternary operator here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried something like this
return (this.userService.findByEmail(email) != null) ? this.userService.findByEmail(email).getPassword().equals(password) : false;
but stylecheck scolded me because of to long code line (((

return (user.getPassword().equals(password)) ? true : false;
}
return false;
}
}
5 changes: 5 additions & 0 deletions src/main/java/mate/academy/service/UserService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ public class UserService {
* Return <code>null</code> if there is no suitable user
*/
public User findByEmail(String email) {
for (User user : users) {
if (user.getEmail().equals(email)) {
return user;
}
}
return null;
}
}
Loading