breaking: migrate to cjs

[Eomm]

fixes #162

I think after this PR, we could ship the v1

WDYT @mateonunez?

[Eomm]

TS is failing 💩

[Eomm]

CC I wrote the TS part with @allevo @lmammino (4 moral support)

[Puppo]

@Eomm and @mateonunez, I think there is the same problem with the CI here

[mateonunez]

Sigh. I wasn't able to reproduce it locally. We need to fix that flaky before v1.0.

Do you have more information about the error, @Puppo? In that case, we can open an issue with all the needed information to reproduce it locally and provide a fix.

[Puppo]

@mateonunez I don't have any info yet. It seems to be stuck but randomly. I'll look it over.

[mateonunez]

The new typing system rocks, man! Thanks a lot.

I think we can send these improvements to v1.0, we just need to verify why tests sometimes struggle with Node v20.

[mateonunez]

Can insert and AnyOrama be removed here? They are no longer used.

[Puppo]

The new typing system rocks, man! Thanks a lot.

I think we can send these improvements to v1.0, we just need to verify why tests sometimes struggle with Node v20.

@mateonunez, the problem with the test is something relative to the reporter; I'm on it to understand the problem; it seems something rests ongoing and doesn't close the process. But it's random and not easy to debug.

[Puppo]

I think this is the issue

[mateonunez]

I think this is the issue

Nice catch, @Puppo!

Any concerns on this, @Eomm? Should we rollback to node-tap in your opinion?

[Eomm]

Should we rollback to node-tap in your opinion?

I would wait a sec for a fix before switching.

Tap changed license and I see everybody is migrating to node test runner.

[Puppo]

Any new here guys?
@mateonunez or @Eomm please, run the CI again meanwhile to check everything is okay.
The error is random so if you try twice or three time you should see the 🟢 light.

[mateonunez]

Any new here guys?
@mateonunez or @Eomm please, run the CI again meanwhile to check everything is okay.
The error is random so if you try twice or three time you should see the 🟢 light.

I saw a new version of Node has been released, but don't know if it fixes the issue you attached. I'll read the changelog later. Meanwhile I've re-run the CI.

[Eomm]

Green

missing approve 😄

[mateonunez]

LGTM

I'll ship the stable version of this plugin tonight.

Thank you so much guys, @Eomm, @Puppo! ♥️