refactor(tests): migrate from tap to node test runners #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
|
The CI got stuck, this is probably the related issue: nodejs/node#49344. In this PR I have added We can remove Thoughts on this? |
|
Seems redis getting stuck, can you take a closer look? |
Signed-off-by: mateonunez <mateonunez95@gmail.com>
mateonunez
force-pushed
the
refactor/remove-tap
branch
from
620fd24 to
cc70131
Compare
|
Green light! ✅ |
package.json
Outdated
| @@ -5,7 +5,7 @@ | |||
| "main": "index.js", | |||
| "types": "index.d.ts", | |||
| "scripts": { | |||
| "test": "standard | snazzy && tap test/*test.js && tsd", | |||
| "test": "standard | snazzy && c8 --100 node --test test/*.js && tsd", | |||
There was a problem hiding this comment.
it was test/*test.js
simone-sanfratello
requested changes
Nov 10, 2023
test/base.test.js
Outdated
| @@ -18,16 +20,16 @@ const dummyStorage = { | |||
| } | |||
|
|
|||
| let redisClient | |||
| before(async (t) => { | |||
| beforeEach(async () => { | |||
There was a problem hiding this comment.
before is still before, not beforeEach
test/base.test.js
Outdated
| redisClient = new Redis() | ||
| }) | ||
|
|
||
| teardown(async (t) => { | ||
| afterEach(async () => { |
There was a problem hiding this comment.
teardown is after
test/storage-redis.test.js
Outdated
| await redisClient.flushall() | ||
| }) | ||
| describe('storage redis', async () => { | ||
| beforeEach(async () => { |
There was a problem hiding this comment.
before instead of beforeEach
| const Redis = require('ioredis') | ||
|
|
||
| const createStorage = require('../src/storage') | ||
| const { Cache } = require('../') | ||
|
|
||
| let redisClient | ||
| before(async (t) => { |
There was a problem hiding this comment.
please keep before and after
There was a problem hiding this comment.
Added in the suite
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
mateonunez
force-pushed
the
refactor/remove-tap
branch
from
2768782 to
d91f0b2
Compare
|
well done :) |
simone-sanfratello
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #98 by migrating the whole codebase of tests that runs server side using the Node Test Runners
test/base.test.jstest/cache.test.jstest/clear.test.jstest/stale.test.jstest/storage-base.test.jstest/storage-memory.test.jstest/storage-redis.test.jstest/transformer.test.jstest/ttl.test.jstest/utils.test.jsI used
tsplwhere required by previous tests. Otherwise I kept the default Node assertions.We need to figure out possibly whether to normalize all assertions under
tsplor proceed to use only if we are going to ensure assertion count.