-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rounding artefacts with dark table row #146
Comments
Honestly, I'm just realized the app that I have developed for 3 years have a CSS override like this.
Stupid past me 🤦, there's no documentation why this CSS rule exist. Perhaps this artefact is the reason... Looking on the commit from 7 years ago, I don't think there's any reason removing border-radius would cause any UI problem. Feel free to create a PR to fix this issue. The line you looking is here : materialize/sass/components/_global.scss Line 446 in eb04cbf
On the other hand, there's materialize/sass/components/_global.scss Lines 417 to 419 in eb04cbf
What do you think about this? Safe to remove both of these rules? @materializecss/members |
I can't find the purpose of using border-radius in table cells, I think we can safely remove it. |
Fix for issue #146 (Rounding artefacts with dark table row)
global.scss contain this style:
The border radius is not visible when the table cell background color is identical to all cells around it.
When highlighting a table row by changing the background color, the area between each adjacent td in that row shows the rounding effects: a few white pixels on every corner.
Material design does not specify any rounding on table cells.
See https://material.io/archive/guidelines/components/data-tables.html
Snippet to reproduce the issue:
Example:
I have not found any component in materializecss where the border rounding of td or th elements is useful. I might have missed one - please reply and let me know.
Proposed solution: change line marked above from 2px to 0.
Environment:
The text was updated successfully, but these errors were encountered: