Fix for issue #146 (Rounding artefacts with dark table row) #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smankusors
reviewed
Jun 17, 2021
| @@ -401,7 +397,7 @@ td, th{ | |||
| display: table-cell; | |||
| text-align: left; | |||
| vertical-align: middle; | |||
| border-radius: 2px; | |||
| border-radius: 0; | |||
There was a problem hiding this comment.
I think this line is also safe to delete... what do you think guys? @materializecss/members
There was a problem hiding this comment.
I would not optimize it more, to avoid the risk of breaking existing applications because of how the styles are used. This is a nice and small pull request as it is now. Let's keep it that way.
|
Hi @RamonvdW, many thanks for your PR =) I've sent you an invitation to the materializecss org as member. Would be great to have you on board 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #146 (Rounding artefacts with dark table row)
Tested with plain and striped tables.