Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #146 (Rounding artefacts with dark table row) #149

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fix for issue #146 (Rounding artefacts with dark table row) #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions sass/components/_global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,10 +371,6 @@ table {
> tr:nth-child(odd) {
background-color: $table-striped-color;
}

> tr > td {
border-radius: 0;
}
}

&.highlight > tbody > tr {
Expand All @@ -401,7 +397,7 @@ td, th{
display: table-cell;
text-align: left;
vertical-align: middle;
border-radius: 2px;
border-radius: 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is also safe to delete... what do you think guys? @materializecss/members

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agree 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not optimize it more, to avoid the risk of breaking existing applications because of how the styles are used. This is a nice and small pull request as it is now. Let's keep it that way.

}

// Responsive Table
Expand Down