fix: derive canonicalize result from UCD #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the case mappings in data always conform to the latest Unicode version.
JLHwung
force-pushed
the
derive-case-data-from-ucd
branch
from
4cabbb8 to
9bea86d
Compare
|
@mathiasbynens Thank you for publishing the new unicode-data releases. This PR is ready for review now. |
JLHwung
commented
Nov 4, 2024
| [0xA7D0, 0xA7D1], | ||
| [0xA7D1, 0xA7D0], | ||
| [0xA7D6, 0xA7D7], | ||
| [0xA7D7, 0xA7D6], | ||
| [0xA7D8, 0xA7D9], | ||
| [0xA7D9, 0xA7D8], | ||
| [0xA7DA, 0xA7DB], | ||
| [0xA7DB, 0xA7DA], | ||
| [0xA7DC, 0x19B], |
There was a problem hiding this comment.
The changes in i-bmp-mappings.js are only due to Unicode 16, where 1C89..1C8A, A7CB..A7CD and A7DA..A7DC are introduced: https://www.unicode.org/Public/UCD/latest/ucd/DerivedAge.txt
The case mapping result no longer depends on the node.js version
JLHwung
force-pushed
the
derive-case-data-from-ucd
branch
from
73370b0 to
17ecf26
Compare
mathiasbynens
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the case mappings data always conforms to the latest Unicode version.
The data is built from my local node-unicode-data working branch for node-unicode/node-unicode-data#78, this PR is pending the new node-unicode-data releases, please don't merge it now.Fixes #106.