Add simple and special case mapping #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
commented
Nov 3, 2024
| // conditions can contain a language ID defined by BCP 47 and casing contexts | ||
| // defined in Table 3-17 Context Specification for Casing | ||
| // https://www.unicode.org/versions/Unicode16.0.0/core-spec/chapter-3/#G54277 | ||
| const conditions = data[4].replaceAll(" ", "--"); |
There was a problem hiding this comment.
Because the language ID may contain -, here we let -- be the separator between the language id and the casing contexts.
There was a problem hiding this comment.
Let's make this an inline comment?
mathiasbynens
approved these changes
Nov 3, 2024
|
Thanks! |
|
Available in v1.6.1 |
|
The https://www.npmjs.com/package/@unicode/unicode-16.0.0?activeTab=code |
Hmm, it’s also missing from the generated output: https://github.com/node-unicode/unicode-16.0.0 |
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add Simple_Case_Mapping and Special_Casing to the package. The new data will enable regexpu-core to correctly generate the case mapping/folding data, especially for those new characters that are not yet covered by the latest runtime.
This PR should unblock mathiasbynens/regexpu-core#106.
To improve the package size, we enabled the compression for case folding data.