Use a different key ID for each complement server #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests may choose to re-use the same homeserver deployment across multiple test cases, each spinning up different complement servers. However, when a complement server happens to have the same hostname and port as a previous one, the homeserver under test may retain cached keys for the old complement server and reject events from the new one. Give each complement server a unique key ID to stop that from happening.
babolivier
approved these changes
Oct 3, 2022
This was referenced Oct 4, 2022
kegsay
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests may choose to re-use the same homeserver deployment across
multiple test cases, each spinning up different complement servers.
However, when a complement server happens to have the same hostname and
port as a previous one, the homeserver under test may retain cached keys
for the old complement server and reject events from the new one.
Give each complement server a unique key ID to stop that from happening.
Thanks to @erikjohnston for suggesting the fix.
Fixes matrix-org/synapse#13975.