Generate unique room IDs when creating rooms #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that room IDs are not re-used across tests, even if a Complement server happens to re-use the same port as a previous one, which reduces noise when searching through logs and prevents homeservers from getting confused when multiple test cases re-use the same homeserver deployment.
DMRobertson
approved these changes
Oct 5, 2022
Comment on lines
+164
to
+169
| // Generate a unique room ID, prefixed with an incrementing counter. | ||
| // This ensures that room IDs are not re-used across tests, even if a Complement server happens | ||
| // to re-use the same port as a previous one, which | ||
| // * reduces noise when searching through logs and | ||
| // * prevents homeservers from getting confused when multiple test cases re-use the same homeserver deployment. | ||
| roomID := fmt.Sprintf("!%d-%s:%s", len(s.rooms), util.RandomString(18), s.serverName) |
There was a problem hiding this comment.
Do we ever delete from or otherwise truncate s.rooms? Is it possible that some race could mean that we reuse a value of len(s.rooms)? (I have no idea what sort of concurrency problems one has to ancipate in Go.)
On second thought: we were using len(s.rooms) before, so this can't be any worse.
There was a problem hiding this comment.
Do we ever delete from or otherwise truncate
s.rooms?
I did a search and can't find anywhere where we do that. I'd expect the random part of the room ID to handle conflicts with len(s.rooms) unless we are unlucky to the degree of ~1/2**107.
kegsay
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that room IDs are not re-used across tests, even if a
Complement server happens to re-use the same port as a previous one,
which reduces noise when searching through logs and prevents homeservers
from getting confused when multiple test cases re-use the same
homeserver deployment.
Fixes matrix-org/synapse#13975 together with #486.