Don't process feed/item titles that aren't actually strings #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
approved these changes
Apr 11, 2023
Very much so. I'll eagerly await #702 landing and start from that. |
Another case of empty-tag with attributes, these would occasionally parse into non-string objects and make us crash when trying to stripHtml on them.
tadzik
force-pushed
the
tadzik/ensure-title-strings
branch
from
93fe518
to
c481fdb
Compare
|
Tested now. This required a fugly amount of mocking, but that might pay off when we add more tests in the future. |
SpiritCroc
added a commit
to SpiritCroc/matrix-hookshot
that referenced
this pull request
Apr 27, 2023
4.0.0 (2023-04-27) ================== Features -------- - Add support for specifying custom templates for feeds. ([\matrix-org#702](matrix-org#702)) - Use SQLite for file-based crypto stores by default, instead of Sled. ([\matrix-org#714](matrix-org#714)) - Notifications for RSS feed failures can now be toggled on and off. The feature is now **off** by default. ([\matrix-org#716](matrix-org#716)) Bugfixes -------- - Fix mishandling of empty feed/item title tags. ([\matrix-org#708](matrix-org#708)) - Add information about GitHub App Installs in 'update' state on the oauth status page. ([\matrix-org#717](matrix-org#717)) - Fix cases of GitHub repos not being bridgable if the GitHub App had to be manually approved. ([\matrix-org#718](matrix-org#718)) - Switch to using Rust for parsing RSS feeds. ([\matrix-org#721](matrix-org#721)) Deprecations and Removals ------------------------- - Add support for Node 20, and drop support for Node 16. ([\matrix-org#724](matrix-org#724)) Internal Changes ---------------- - Ensure all Hookshot specific metrics have a `hookshot_` prefix. ([\matrix-org#701](matrix-org#701)) - Update dependency used in Generic Webhook JS functions to fix a security flaw. ([\matrix-org#705](matrix-org#705)) - Switch to using Rust for parsing RSS feeds. ([\matrix-org#709](matrix-org#709)) - Update the README with a prettier set of features. ([\matrix-org#726](matrix-org#726)) - Update `yaml` dependency to `2.2.2` ([\matrix-org#728](matrix-org#728)) Conflicts: src/feeds/FeedReader.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another case of empty-tag with attributes, these would occasionally parse into non-string objects and make us crash when trying to stripHtml on them.
Fixes #706