-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow usage of the SQLite-based crypto store #714
Conversation
TODO: cut release of the
Could that failure be related to matrix-org/matrix-rust-sdk#968 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm a dumb and didn't review comment the first two comments, but anyway, some 🥫 for 💭 )
Barring review, this PR should now be done, other than updating the bot-sdk dependency (once it becomes available). The yarn script for resetting crypto state should help fix "stuck" Hookshots that crash on startup with E2EE errors, or fail to decrypt messages even after resetting room keys (like with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest of the changes look good, but a few things in the new script look suspect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy once CI passes
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
Also document its usage & when it may be necessary to use it.
- add trailing semicolons - remove redundant `Promise.resolve`s
- Move error object to parameter - Rename logger
and call it to let the process exit cleanly
Use release with SQLite crypto store support
461ff54
to
828d0ab
Compare
4.0.0 (2023-04-27) ================== Features -------- - Add support for specifying custom templates for feeds. ([\matrix-org#702](matrix-org#702)) - Use SQLite for file-based crypto stores by default, instead of Sled. ([\matrix-org#714](matrix-org#714)) - Notifications for RSS feed failures can now be toggled on and off. The feature is now **off** by default. ([\matrix-org#716](matrix-org#716)) Bugfixes -------- - Fix mishandling of empty feed/item title tags. ([\matrix-org#708](matrix-org#708)) - Add information about GitHub App Installs in 'update' state on the oauth status page. ([\matrix-org#717](matrix-org#717)) - Fix cases of GitHub repos not being bridgable if the GitHub App had to be manually approved. ([\matrix-org#718](matrix-org#718)) - Switch to using Rust for parsing RSS feeds. ([\matrix-org#721](matrix-org#721)) Deprecations and Removals ------------------------- - Add support for Node 20, and drop support for Node 16. ([\matrix-org#724](matrix-org#724)) Internal Changes ---------------- - Ensure all Hookshot specific metrics have a `hookshot_` prefix. ([\matrix-org#701](matrix-org#701)) - Update dependency used in Generic Webhook JS functions to fix a security flaw. ([\matrix-org#705](matrix-org#705)) - Switch to using Rust for parsing RSS feeds. ([\matrix-org#709](matrix-org#709)) - Update the README with a prettier set of features. ([\matrix-org#726](matrix-org#726)) - Update `yaml` dependency to `2.2.2` ([\matrix-org#728](matrix-org#728)) Conflicts: src/feeds/FeedReader.ts
Fixes #609