Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tombstone bugfixes #1001

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Tombstone bugfixes #1001

merged 2 commits into from
Jul 29, 2019

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Jul 29, 2019 •
edited
Loading

This sets some limits on room upgrade history:

  • Tombstones which self reference the room they are sent to cause the history fetching process to cease.
  • If the array which stores historical rooms ever contains two of the same room, the history fetcher returns early.

@Half-Shot Half-Shot requested a review from a team July 29, 2019 14:29
@Half-Shot Half-Shot mentioned this pull request Jul 29, 2019
Closed
@turt2live
Copy link
Member

@Half-Shot this needs a description, and a better title please (the titles are our changelog)

turt2live
turt2live approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@turt2live turt2live merged commit 9a8af05 into develop Jul 29, 2019
@turt2live turt2live mentioned this pull request Jul 29, 2019
Closed
@t3chguy t3chguy deleted the hs/recursive-tombstone-fixes branch May 10, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @turt2live