notify devices when we don't send them keys #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2020
turt2live
approved these changes
Jan 6, 2020
| }; | ||
|
|
||
| export const WITHHELD_MESSAGES = { | ||
| "m.unverified": "The sender has disabled encrypting to unverified devices.", |
There was a problem hiding this comment.
shouldn't these also be org.matrix for now? (annoyingly)
There was a problem hiding this comment.
I thought about that, but since they only appear in org.matrix.room_key.withheld messages, I think it should be fine.
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part of MSC2399 (notifications on initial key sending, but not on keyshare requests, and does not properly handle
m.no_olmyet -- the remaining functionality will come in a future PR).