Fix bug where calls could break if rejected from somewhere else #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e else When callEventHandler passed a reject event to the call object, it assumed that always caused the call to end and deleted it from the list, so it never got any more events. The point of a reject is that it doesn't end the call if it's already been picked up though. This only removes the call if it's actually ended.
dbkr
changed the title
SimonBrandner
approved these changes
Feb 21, 2022
t3chguy
approved these changes
Feb 21, 2022
t3chguy
reviewed
Feb 21, 2022
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Mar 5, 2022
* Return send event response from MSC3089Branch.createNewVersion() ([\matrix-org#2186](matrix-org#2186)). * Add functions to support refresh tokens ([\matrix-org#2178](matrix-org#2178)). * [Release] Fix bug with the /hierarchy API sending invalid requests ([\matrix-org#2202](matrix-org#2202)). * Fix bug where calls could break if rejected from somewhere else ([\matrix-org#2189](matrix-org#2189)). * Fix camera stuck on after call transfer ([\matrix-org#2188](matrix-org#2188)). * Fix synthetic read receipt handling ([\matrix-org#2174](matrix-org#2174)). Fixes element-hq/element-web#21016. * Revert "Sign backup with cross-signing key when we reset it." ([\matrix-org#2175](matrix-org#2175)). * Sign backup with cross-signing key when we reset it. ([\matrix-org#2170](matrix-org#2170)). * Fix error in uploadContent() when file is empty under Node.js ([\matrix-org#2155](matrix-org#2155)). * Check the backup info against the stored private key when determining trust. ([\matrix-org#2167](matrix-org#2167)). * Back up keys before logging out ([\matrix-org#2158](matrix-org#2158)). Fixes element-hq/element-web#13151.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When callEventHandler passed a reject event to the call object, it assumed
that always caused the call to end and deleted it from the list, so it
never got any more events. The point of a reject is that it doesn't
end the call if it's already been picked up though. This only removes
the call if it's actually ended.
Here's what your changelog entry will look like:
🐛 Bug Fixes