Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where calls could break if rejected from somewhere else #2189

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Fix bug where calls could break if rejected from somewhere else #2189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2189a9d
Fix bug where calls could ignore new events of rejected from somewher…
dbkr Feb 21, 2022
d5d53ad
Use ts-expect-error
dbkr Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/webrtc/callEventHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,11 @@ export class CallEventHandler {
} else {
call.onRejectReceived(content as MCallHangupReject);
}
this.calls.delete(content.call_id);

// @ts-expect-error typescript thinks the state can't be 'ended' because we're
// inside the if block where it wasn't, but it could have changed because
// on[Hangup|Reject]Received are side-effecty.
if (call.state === CallState.Ended) this.calls.delete(content.call_id);
}
}
return;
Expand Down