Implement changes to MSC2285 (private read receipts) #2221
Merged
+208
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
This was referenced Mar 5, 2022
SimonBrandner
force-pushed
the
feature/private-read-receipts
branch
from
c3a3d38
to
f05b064
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2221 +/- ##
===========================================
+ Coverage 59.76% 59.88% +0.11%
===========================================
Files 91 91
Lines 16456 16472 +16
Branches 3801 3807 +6
===========================================
+ Hits 9835 9864 +29
+ Misses 6621 6608 -13
|
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
force-pushed
the
feature/private-read-receipts
branch
from
f05b064
to
2845dcc
Compare
SimonBrandner
changed the title
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
…read-receipts Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
…read-receipts Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
…read-receipts Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
…read-receipts Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
changed the title
t3chguy
reviewed
May 6, 2022
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
t3chguy
reviewed
May 6, 2022
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
t3chguy
approved these changes
May 6, 2022
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
May 28, 2022
* Implement changes to MSC2285 (private read receipts) ([\matrix-org#2221](matrix-org#2221)). * Add support for HTML renderings of room topics ([\matrix-org#2272](matrix-org#2272)). * Add stopClient parameter to MatrixClient::logout ([\matrix-org#2367](matrix-org#2367)). * registration: add function to re-request email token ([\matrix-org#2357](matrix-org#2357)). * Remove hacky custom status feature ([\matrix-org#2350](matrix-org#2350)). * Remove default push rule override for MSC1930 ([\matrix-org#2376](matrix-org#2376)). Fixes element-hq/element-web#15439. * Tweak thread creation & event adding to fix bugs around relations ([\matrix-org#2369](matrix-org#2369)). Fixes element-hq/element-web#22162 and element-hq/element-web#22180. * Prune both clear & wire content on redaction ([\matrix-org#2346](matrix-org#2346)). Fixes element-hq/element-web#21929. * MSC3786: Add a default push rule to ignore `m.room.server_acl` events ([\matrix-org#2333](matrix-org#2333)). Fixes element-hq/element-web#20788.
gleachkr
added a commit
to opentower/populus-viewer
that referenced
this pull request
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: enhancement
Implement changes to MSC2285 (hidden read receipts)
Requires matrix-org/matrix-react-sdk#7993
Requires matrix-org/synapse#12168
The changes in this PR shouldn't affect any clients which don't currently use the opts params.
sendReadReceipt(event: MatrixEvent, receiptType = ReceiptType.Read, callback?: Callback)The
optsparam has been replaced withreceiptType: ReceiptType. By default this isReceiptType.Readand any other value is experimental.setRoomReadMarkers(roomId: string, rmEventId: string, rrEvent?: MatrixEvent, rpEvent?: MatrixEvent)The
optsparam has been replaced withrpEvent?: MatrixEvent. This param is optional and experimental. It allows you to specify a private read receipt not visible to other userssetRoomReadMarkersHttpRequest(roomId: string, rmEventId: string, rrEventId: string, rpEventId: string)The
optsparam has been replaced withrpEventId: string. This param is optional and experimental. It allows you to specify a private read receipt not visible to other usersHere's what your changelog entry will look like:
🚨 BREAKING CHANGES