Element-R: Fix resource leaks in verification logic #4263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only reason it was an inner function in the first place was to avoid storing a reference in the class to `outgoingRequestProcessor`. That changed with d1dec4c.
|
I'm going to split this into two PRs (done) |
richvdh
force-pushed
the
rav/element-r/fix_verification_leak
branch
from
90e0ec3
to
dc2bed9
Compare
andybalaam
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of reference cycles which could cause objects to be leaked, ultimately meaning that we hold open a connection to IndexedDB, exacerbating element-hq/element-web#25779.
Requires #4264
Should be reviewable commit-by-commit.