Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add a setting to allow users to set account-wide custom notification sound #10494

Closed
wants to merge 34 commits into from
Closed

Add a setting to allow users to set account-wide custom notification sound #10494

wants to merge 34 commits into from

Commits on Mar 31, 2023

  1. Add custom notification setting 

    - extract NotificationSound.tsx component
- rename getSoundForRoom, generalize function usage
- rename unnecessarily short variable name
    @kenwuuu
    kenwuuu committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    c97f619 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/custom_global_notification_sound

    @kenwuuu
    kenwuuu committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    164dc99 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2023

  1. Merge branch 'develop' into feature/custom_global_notification_sound

    @kenwuuu
    kenwuuu committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    cef6c6d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. Call NotificationSound with roomId

    @kenwuuu
    kenwuuu committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    b2032f1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/custom_global_notification_sound

    @kenwuuu
    kenwuuu committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    3839113 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. remove comment

    @kenwuuu
    kenwuuu committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    c6c5112 View commit details
    Browse the repository at this point in the history

  2. Update pills-click-in-app.spec.ts - use Cypress Testing Library (matr… 

    …ix-org#10582)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    41c0b08 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. #21451 Fix WebGL disabled error message (matrix-org#10589) 

    * #21451 Fix WebGl disabled error message

* #21451 Fix WebGl disabled error message

Signed-off-by: Rashmit Pankhania <rashmitpankhania@gmail.com>
Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix message

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix ordering of cases in LocationShareErrors.ts

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix linting LocationPicker.tsx

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix eslint

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix file encoding for i18n CI issue

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix ts strict CI issue

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

---------

Signed-off-by: Rashmit Pankhania <rashmitpankhania@gmail.com>
Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>
Co-authored-by: Rashmit Pankhania <raspankh@publicisgroupe.net>
Co-authored-by: Kerry <kerrya@element.io>
    @rashmitpankhania
    3 people committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    7751f9c View commit details
    Browse the repository at this point in the history

  2. Update stickers.spec.ts - use Cypress Testing Library (matrix-org#10622) 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    9385881 View commit details
    Browse the repository at this point in the history

  3. Conform more of the codebase to strictNullChecks (matrix-org#10602) 

    * Conform more of the codebase to `strictNullChecks`

* Conform more of the codebase to `strictNullChecks`

* Fix types
    @t3chguy
    t3chguy committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    daad630 View commit details
    Browse the repository at this point in the history

  4. Make test ID compatible with findByTestId() of Cypress Testing Library ( 

    matrix-org#10617)

'data-test-id' is not discoverable with findByTestId() of Cypress Testing Library.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    8a4a584 View commit details
    Browse the repository at this point in the history

  5. Update room.spec.ts - use Cypress Testing Library (matrix-org#10608) 

    * Update room.spec.ts - use Cypress Testing Library

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Empty commit

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    9d8d610 View commit details
    Browse the repository at this point in the history

  6. Apply strictNullChecks to Markdown.ts (matrix-org#10623) 

    Co-authored-by: Kerry <kerrya@element.io>
    @timjamello
    timjamello and Kerry committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    1d9df7e View commit details
    Browse the repository at this point in the history

  7. Update location.spec.ts - use Cypress Testing Library (matrix-org#1… 

    …0612)

* Update location.spec.ts - use Cypress Testing Library

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Make the test id of location share option discoverable with findByTestId()

findByTestId seeks for data-testid, instead of data-test-id.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    8125649 View commit details
    Browse the repository at this point in the history

  8. Update pollHistory.spec.ts - use Cypress Testing Library (matrix-org#… 

    …10611)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    816a078 View commit details
    Browse the repository at this point in the history

  9. Conform more of the codebase to strictNullChecks (matrix-org#10607) 

    * Conform more of the codebase to `strictNullChecks`

* Conform more of the codebase to `strictNullChecks`

* Fix types

* Conform more of the codebase to `strictNullChecks`

* Conform more of the codebase to `strictNullChecks`
    @t3chguy
    t3chguy committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    56e4ae4 View commit details
    Browse the repository at this point in the history

  10. Update Cypress test files under support/ directory - use Cypress Te… 

    …sting Library (matrix-org#10619)

* Update support files - use Cypress Testing Library

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix openMessageComposerOptions()

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    4c0efc5 View commit details
    Browse the repository at this point in the history

  11. Update send_event.spec.ts - use Cypress Testing Library (matrix-org#1… 

    …0613)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    8471e45 View commit details
    Browse the repository at this point in the history

  12. Update right-panel.spec.ts - use Cypress Testing Library (matrix-org#… 

    …10539)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    4d859a3 View commit details
    Browse the repository at this point in the history

  13. Replace hardcoded strings with MsgType constants (matrix-org#10604) 

    * replace hardcoded strings with MsgType constants

* fix import and revert comments

Signed-off-by: Ken Wu kenqiwu@gmail.com

* fix import

Signed-off-by: Ken Wu kenqiwu@gmail.com

---------

Signed-off-by: Ken Wu kenqiwu@gmail.com
    @kenwuuu
    kenwuuu committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    dc4bb23 View commit details
    Browse the repository at this point in the history

  14. Update room-directory.spec.ts - use Cypress Testing Library (matrix-o… 

    …rg#10596)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    013b720 View commit details
    Browse the repository at this point in the history

  15. Update file-panel.spec.ts - use Cypress Testing Library (matrix-org#1… 

    …0574)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    9c277d6 View commit details
    Browse the repository at this point in the history

  16. Make SonarCloud happier about our code quality (matrix-org#10630)

    @t3chguy
    t3chguy committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    568ec77 View commit details
    Browse the repository at this point in the history

  17. Update spotlight.spec.ts - use Cypress Testing Library (matrix-org#10621 

    )

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    7114f82 View commit details
    Browse the repository at this point in the history

  18. Update lazy-loading.spec.ts - use Cypress Testing Library (matrix-org… 

    …#10591)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    a092a91 View commit details
    Browse the repository at this point in the history

  19. Fix view source from edit history dialog always showing latest event (m… 

    …atrix-org#10626)
    @t3chguy
    t3chguy committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    270a26d View commit details
    Browse the repository at this point in the history

  20. Fix multiple accessibility defects identified by AXE (matrix-org#10606) 

    * Mark effects overlay canvas as aria hidden

* Ensure date separators aren't seen as focusable aria separators

* Fix

* Fix font slider not having aria label

* Add missing aria labels

* Fix settings flags setting aria-checked={null}

* Update snapshots
    @t3chguy
    t3chguy committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    1a0e5c1 View commit details
    Browse the repository at this point in the history

  21. Update polls.spec.ts - use Cypress Testing Library (matrix-org#10609) 

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    @luixxiul
    luixxiul committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    d1461d3 View commit details
    Browse the repository at this point in the history

  22. Add missing rel noreferrer noopener attributes (matrix-org#10629)

    @t3chguy
    t3chguy committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    6bf1815 View commit details
    Browse the repository at this point in the history

  23. Add custom notification setting 

    - extract NotificationSound.tsx component
- rename getSoundForRoom, generalize function usage
- rename unnecessarily short variable name
    @kenwuuu
    kenwuuu committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    2cf6782 View commit details
    Browse the repository at this point in the history

  24. Call NotificationSound with roomId

    @kenwuuu
    kenwuuu committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    aa90786 View commit details
    Browse the repository at this point in the history

  25. remove comment

    @kenwuuu
    kenwuuu committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    037be66 View commit details
    Browse the repository at this point in the history

  26. add aria-label

    @kenwuuu
    kenwuuu committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    1c64888 View commit details
    Browse the repository at this point in the history

  27. Merge remote-tracking branch 'origin/feature/custom_global_notificati… 

    …on_sound' into feature/custom_global_notification_sound

# Conflicts:
#	src/components/views/settings/NotificationSound.tsx
    @kenwuuu
    kenwuuu committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    37f35d1 View commit details
    Browse the repository at this point in the history