This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Notify users about denied access on ask to join rooms #11479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
…into nurjinjafar/notify_users_about_denied_access_on_ask_to_join_rooms
Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>
Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>
Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
Signed-off-by: AHMAD KADRI <52747422+ahmadkadri@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Fix avatar initial centering in pills for bubbles * Express user info avatar size in pixes * fix link pill icon * Fix snapshot test
github-actions
bot
added
the
Z-Community-PR
Signed-off-by: nurjinn jafar <nurjin.jafar@nordeck.net>
…enied_access_on_ask_to_join_rooms' into nurjinjafar/notify_users_about_denied_access_on_ask_to_join_rooms
…into nurjinjafar/notify_users_about_denied_access_on_ask_to_join_rooms
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We https://github.com/nordeck are currently implementing the knock rooms behind the feature flag feature_ask_to_join (introduced in #11182).
This pull request introduces the deny mask for requests.
Epic: element-hq/element-web#18655
Relates to
#11404
matrix-org/matrix-js-sdk#3673
#11353
matrix-org/matrix-js-sdk#3647
#11248
#11182
element-hq/element-web#25923
Screens
Checklist
Here's what your changelog entry will look like:
✨ Features
Introduce Deny access request mask on Ask-to-join rooms (#11479). Contributed by @nurjinjafar.
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.