Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Knocking on Element Web #18655

Open
4 of 6 tasks
jakewb-b opened this issue Aug 20, 2021 · 26 comments
Open
4 of 6 tasks

Implement Knocking on Element Web #18655

jakewb-b opened this issue Aug 20, 2021 · 26 comments
Assignees

Comments

@jakewb-b
Copy link

jakewb-b commented Aug 20, 2021

Links

Mobile (out of scope for this issue): See element-hq/element-android#3875 and element-hq/element-ios#4731

Tasks

  1. A-Knocking O-Uncommon S-Major T-Defect Z-Labs
  2. A-Knocking O-Uncommon S-Minor T-Defect Z-Labs
  3. A-Knocking T-Defect Z-Labs
  4. A-Knocking O-Uncommon S-Major T-Defect Z-Labs
  5. A-Join A-User-Experience O-Occasional S-Minor T-Defect
  6. A-Knocking A-Spaces O-Uncommon S-Major T-Defect Z-Labs
    t3chguy
@Mikaela
Copy link
Contributor

Mikaela commented Dec 9, 2021

I am unable to open either of the links from the original submission and am wondering whether it's noted that this is part of Matrix protocol specification version 1.1?

@turt2live
Copy link
Member

Screenshots of the designs for inspiration (in no particular order):
ModeratorView
RequestSent
RequestToJoin
CreateKnockableRoom

@noantiq
Copy link

noantiq commented Apr 12, 2022

I was wondering, why would you move the "People" tab to settings instead of leaving it in the side panel and adding a new category for Access Requests in the same way as there is a category for invited people already?

@t3chguy
Copy link
Member

t3chguy commented Apr 12, 2022

I was wondering, why would you move the "People" tab to settings instead of leaving it in the side panel and adding a new category for Access Requests in the same way as there is a category for invited people already?

Its not moved, the People right panel card remains, just won't show knocks to prevent noise/spam.

Settings already has a people section (people with non-default power levels) - this just extends that list.

image

@turt2live
Copy link
Member

it would actually be its own tab - the existing roles & permissions tab gets split in two for clarity. The member list on the right side of the room remains unchanged in any case, however.

@enekonieto
Copy link

Would it be interesting if members with enough privileges see the knock in the timeline?

@Mikaela
Copy link
Contributor

Mikaela commented Apr 28, 2022

If I understand correctly, everyone in the room will see the knocking as it's a membership event, unless Element Web especially hides that (which I imagine would then be visible through /devtools or another client). To answer the knock necessary PL is the one to invite or kick (or ban)

@enekonieto
Copy link

enekonieto commented Apr 28, 2022

I think the event in the timeline should have the Accept/Reject buttons for users with enough PL. I comment this because I don't see the timeline in the prototype sent by @turt2live.

The settings screen being the only way to accept knocks seems not very comfortable to me (I don't know if that's the idea).

@Mikaela
Copy link
Contributor

Mikaela commented Aug 11, 2022

Does this issue include that when join rule is set to knock or knock_restricted, Element Web settings "who can join this room" has radio button menu with nothing checked? Or does knock_restricted need a new issue?

My room versions are 9 and 10.

@turt2live
Copy link
Member

It would be a later stage of development

@Mikaela
Copy link
Contributor

Mikaela commented Nov 15, 2022

The previous time I used knocking was yesterday when we bridged an ICT team from Telegram to Matrix. We couldn't use restricted as that would have required us to already have a room with everyone and due to the room's nature we couldn't make it fully public.

I am also utilising knock_restricted in my personal rooms a lot.

Thus I would like to ask if there has been any progress with supporting knocking in Elements as it's a feature of Matrix Spec 1.1 with Matrix Spec 1.5 being around the coner? matrix-org/matrix-spec#1337

@turt2live
Copy link
Member

Knocking is still low on the list of priorities. Due to scheduling, we're expecting to make more forward progress next summer.

@Mikaela
Copy link
Contributor

Mikaela commented Nov 15, 2022

Thanks for the update, I am happy to hear that knocking is on the list of priorities even if not that high on it

@rettichschnidi
Copy link

rettichschnidi commented Oct 19, 2023

Tried the current state, and seems very well done to me. Thanks!

Regarding spaces: Are there any ideas/plans on making knocking work for them too? As of Element Web 1.11.46, I can enable knocking for spaces, and users can knock, but the admin of the space does not get a notification about the request, thus is not able to accept/deny them.

@Sun-Laura
Copy link

As mentioned some months ago we contributed to the knocking feature for the past few weeks. Our focus is still the implementation in the rooms.
As you @rettichschnidi mentioned, the knocking for spaces might be also a great value. Despite this it is not our focus yet, maybe Element itself has a more concrete plan for spaces or someone else can take over to contribute. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests