Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add e2e tests for the knocking feature #11803

Merged
merged 13 commits into from
Nov 7, 2023
Merged

Add e2e tests for the knocking feature #11803

merged 13 commits into from
Nov 7, 2023

Conversation

maheichyk
Copy link
Contributor

@maheichyk maheichyk commented Oct 26, 2023 •
edited by github-actions bot
Loading

This PR adds e2e tests for the knocking feature

Epic: element-hq/element-web#18655

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Type: task

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Oct 26, 2023
@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 26, 2023
Add e2e tests for knocking
d616c01 
Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
Add e2e tests for knocking into public knock rooms
48009df 
Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
@maheichyk maheichyk changed the title Add e2e test for the knocking feature Add e2e tests for the knocking feature Oct 27, 2023
Smaller changes
cb4a22a 
Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
@maheichyk maheichyk marked this pull request as ready for review October 27, 2023 14:20
@maheichyk maheichyk requested a review from a team as a code owner October 27, 2023 14:20
Remove room disappear check when forgotten due to exising issue
7fa9300 
Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
@maheichyk
Copy link
Contributor Author

@kerryarchibald, @germain-gg could you please review?

@Johennes Johennes marked this pull request as draft November 7, 2023 07:34
@Johennes Johennes marked this pull request as ready for review November 7, 2023 07:35
MidhunSureshR
MidhunSureshR reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will request a re-review from the team so that someone else can pick this up

@MidhunSureshR MidhunSureshR requested review from a team, florianduros and MidhunSureshR and removed request for a team and MidhunSureshR November 7, 2023 09:11
@Johennes Johennes removed the Z-Community-PR Issue is solved by a community member's PR label Nov 7, 2023
florianduros
florianduros approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@florianduros florianduros added this pull request to the merge queue Nov 7, 2023
Merged via the queue into matrix-org:develop with commit ea64875 Nov 7, 2023
19 checks passed
@maheichyk maheichyk deleted the nic/feat/e2e-knock branch November 7, 2023 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MidhunSureshR MidhunSureshR MidhunSureshR left review comments

@florianduros florianduros florianduros approved these changes

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maheichyk @florianduros @MidhunSureshR @Johennes