This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix flaky receipt and redaction tests by pausing between message sends #11661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Task
3 tasks
kerryarchibald
approved these changes
Sep 26, 2023
|
Force-merged since this was blocked by a separate flake that I am working on now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like sometimes events never make it to the timeline if we send them too quickly. This obviously needs fixing, but first, make the tests less flaky, and second fix stuck notifications.
This change is marked as an internal change (Task), so will not be included in the changelog.