This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove logging which has saved its purpose #8795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Task
robintown
reviewed
Jul 1, 2022
There was a problem hiding this comment.
It looks like this logging was added to debug a variety of issues, some of which are still open. Are we sure they aren't still needed for those?
| @@ -605,9 +531,6 @@ class TimelinePanel extends React.Component<IProps, IState> { | |||
| case "ignore_state_changed": | |||
| this.forceUpdate(); | |||
| break; | |||
| case Action.DumpDebugLogs: | |||
There was a problem hiding this comment.
I assume the action could be removed now too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes matrix-org/matrix-js-sdk#2444
This change is marked as an internal change (Task), so will not be included in the changelog.