Remove logging which has saved its purpose

src/components/structures/RoomView.tsx

@@ -446,31 +446,23 @@ export class RoomView extends React.Component<IRoomProps, IRoomState> {
                 );
             }
 
-            // If we have an initial event, we want to reset the event pixel offset to ensure it ends up
-            // visible
+            // If we have an initial event, we want to reset the event pixel offset to ensure it ends up visible
             newState.initialEventPixelOffset = null;
 
             const thread = initialEvent?.getThread();
-            if (thread && !initialEvent?.isThreadRoot) {
+            if (!thread || initialEvent?.isThreadRoot) {
+                newState.initialEventId = initialEventId;
+                newState.isInitialEventHighlighted = RoomViewStore.instance.isInitialEventHighlighted();
+                newState.initialEventScrollIntoView = RoomViewStore.instance.initialEventScrollIntoView();
+            }
+
+            if (thread) {
                 showThread({
                     rootEvent: thread.rootEvent,
                     initialEvent,
                     highlighted: RoomViewStore.instance.isInitialEventHighlighted(),
                     scroll_into_view: RoomViewStore.instance.initialEventScrollIntoView(),
                 });
-            } else {
-                newState.initialEventId = initialEventId;
-                newState.isInitialEventHighlighted = RoomViewStore.instance.isInitialEventHighlighted();
-                newState.initialEventScrollIntoView = RoomViewStore.instance.initialEventScrollIntoView();
-
-                if (thread && initialEvent?.isThreadRoot) {
-                    showThread({
-                        rootEvent: thread.rootEvent,
-                        initialEvent,
-                        highlighted: RoomViewStore.instance.isInitialEventHighlighted(),
-                        scroll_into_view: RoomViewStore.instance.initialEventScrollIntoView(),
-                    });
-                }
             }
         }
 

src/components/structures/TimelinePanel.tsx

@@ -374,80 +374,6 @@ class TimelinePanel extends React.Component<IProps, IState> {
         }
     }
 
-    /**
-     * Logs out debug info to describe the state of the TimelinePanel and the
-     * events in the room according to the matrix-js-sdk. This is useful when
-     * debugging problems like messages out of order, or messages that should
-     * not be showing up in a thread, etc.
-     *
-     * It's too expensive and cumbersome to do all of these calculations for
-     * every message change so instead we only log it out when asked.
-     */
-    private onDumpDebugLogs = (): void => {
-        const room = this.props.timelineSet.room;
-        // Get a list of the event IDs used in this TimelinePanel.
-        // This includes state and hidden events which we don't render
-        const eventIdList = this.state.events.map((ev) => ev.getId());
-
-        // Get the list of actually rendered events seen in the DOM.
-        // This is useful to know for sure what's being shown on screen.
-        // And we can suss out any corrupted React `key` problems.
-        let renderedEventIds: string[];
-        const messagePanel = this.messagePanel.current;
-        if (messagePanel) {
-            const messagePanelNode = ReactDOM.findDOMNode(messagePanel) as Element;
-            if (messagePanelNode) {
-                const actuallyRenderedEvents = messagePanelNode.querySelectorAll('[data-event-id]');
-                renderedEventIds = [...actuallyRenderedEvents].map((renderedEvent) => {
-                    return renderedEvent.getAttribute('data-event-id');
-                });
-            }
-        }
-
-        // Get the list of events and threads for the room as seen by the
-        // matrix-js-sdk.
-        let serializedEventIdsFromTimelineSets: { [key: string]: string[] }[];
-        let serializedEventIdsFromThreadsTimelineSets: { [key: string]: string[] }[];
-        const serializedThreadsMap: { [key: string]: any } = {};
-        if (room) {
-            const timelineSets = room.getTimelineSets();
-            const threadsTimelineSets = room.threadsTimelineSets;
-
-            // Serialize all of the timelineSets and timelines in each set to their event IDs
-            serializedEventIdsFromTimelineSets = serializeEventIdsFromTimelineSets(timelineSets);
-            serializedEventIdsFromThreadsTimelineSets = serializeEventIdsFromTimelineSets(threadsTimelineSets);
-
-            // Serialize all threads in the room from theadId -> event IDs in the thread
-            room.getThreads().forEach((thread) => {
-                serializedThreadsMap[thread.id] = {
-                    events: thread.events.map(ev => ev.getId()),
-                    numTimelines: thread.timelineSet.getTimelines().length,
-                    liveTimeline: thread.timelineSet.getLiveTimeline().getEvents().length,
-                    prevTimeline: thread.timelineSet.getLiveTimeline().getNeighbouringTimeline(Direction.Backward)
-                        ?.getEvents().length,
-                    nextTimeline: thread.timelineSet.getLiveTimeline().getNeighbouringTimeline(Direction.Forward)
-                        ?.getEvents().length,
-                };
-            });
-        }
-
-        const timelineWindowEventIds = this.timelineWindow.getEvents().map(ev => ev.getId());
-        const pendingEvents = this.props.timelineSet.getPendingEvents().map(ev => ev.getId());
-
-        logger.debug(
-            `TimelinePanel(${this.context.timelineRenderingType}): Debugging info for ${room?.roomId}\n` +
-            `\tevents(${eventIdList.length})=${JSON.stringify(eventIdList)}\n` +
-            `\trenderedEventIds(${renderedEventIds?.length ?? 0})=` +
-            `${JSON.stringify(renderedEventIds)}\n` +
-            `\tserializedEventIdsFromTimelineSets=${JSON.stringify(serializedEventIdsFromTimelineSets)}\n` +
-            `\tserializedEventIdsFromThreadsTimelineSets=` +
-            `${JSON.stringify(serializedEventIdsFromThreadsTimelineSets)}\n` +
-            `\tserializedThreadsMap=${JSON.stringify(serializedThreadsMap)}\n` +
-            `\ttimelineWindowEventIds(${timelineWindowEventIds.length})=${JSON.stringify(timelineWindowEventIds)}\n` +
-            `\tpendingEvents(${pendingEvents.length})=${JSON.stringify(pendingEvents)}`,
-        );
-    };
-
     private onMessageListUnfillRequest = (backwards: boolean, scrollToken: string): void => {
         // If backwards, unpaginate from the back (i.e. the start of the timeline)
         const dir = backwards ? EventTimeline.BACKWARDS : EventTimeline.FORWARDS;
@@ -605,9 +531,6 @@ class TimelinePanel extends React.Component<IProps, IState> {
             case "ignore_state_changed":
                 this.forceUpdate();
                 break;
-            case Action.DumpDebugLogs:
-                this.onDumpDebugLogs();
-                break;
         }
     };
 
@@ -1767,30 +1690,4 @@ class TimelinePanel extends React.Component<IProps, IState> {
     }
 }
 
-/**
- * Iterate across all of the timelineSets and timelines inside to expose all of
- * the event IDs contained inside.
- *
- * @return An event ID list for every timeline in every timelineSet
- */
-function serializeEventIdsFromTimelineSets(timelineSets): { [key: string]: string[] }[] {
-    const serializedEventIdsInTimelineSet = timelineSets.map((timelineSet) => {
-        const timelineMap = {};
-
-        const timelines = timelineSet.getTimelines();
-        const liveTimeline = timelineSet.getLiveTimeline();
-
-        timelines.forEach((timeline, index) => {
-            // Add a special label when it is the live timeline so we can tell
-            // it apart from the others
-            const isLiveTimeline = timeline === liveTimeline;
-            timelineMap[isLiveTimeline ? 'liveTimeline' : `${index}`] = timeline.getEvents().map(ev => ev.getId());
-        });
-
-        return timelineMap;
-    });
-
-    return serializedEventIdsInTimelineSet;
-}
-
 export default TimelinePanel;