Ability to sign in by QR code and sign another device in by QR code + verification + cross-signing #9303
Conversation
hughns
added
the
T-Enhancement
… t3chguy/fetch � Conflicts: � src/components/structures/UploadBar.tsx
hughns
force-pushed
the
hughns/http-rendezvous
branch
from
17c76ef
to
0cf4c73
Compare
| @@ -1579,6 +1579,11 @@ | |||
| "Privacy": "Privacy", | |||
| "Share anonymous data to help us identify issues. Nothing personal. No third parties.": "Share anonymous data to help us identify issues. Nothing personal. No third parties.", | |||
| "Sessions": "Sessions", | |||
| "You can use this device to sign in a new device with a QR code. ": "You can use this device to sign in a new device with a QR code. ", | |||
There was a problem hiding this comment.
This has an extra space at the end of it that shouldn't be there :)
There was a problem hiding this comment.
it's been mentioned that these spaces might be intentional: this is a sign that the wrong amount of the string is under the translations. We can't join strings in-code because some languages just don't work like that. Instead, we put entire paragraphs under a single string (repeating some copy if required).
| "Please ensure that you know the origin of this code. By linking devices, you will provide someone with full access to your account.": "Please ensure that you know the origin of this code. By linking devices, you will provide someone with full access to your account.", | ||
| "Scan the QR code below with your device that’s signed out.": "Scan the QR code below with your device that’s signed out.", | ||
| "Start at the sign in screen": "Start at the sign in screen", | ||
| "Select ‘Scan QR code’": "Select ‘Scan QR code’", |
There was a problem hiding this comment.
I can't remember, but I don't think we're supposed to use magic quotes in strings - check with design to see if they care.
There was a problem hiding this comment.
Ironically the magic quotes came from them...
There was a problem hiding this comment.
Yup, it's on all of the designs but it's been declared a non-feature in the past (just that their operating system isn't worth fighting to get rid of them at design time)
| @@ -1579,6 +1579,11 @@ | |||
| "Privacy": "Privacy", | |||
| "Share anonymous data to help us identify issues. Nothing personal. No third parties.": "Share anonymous data to help us identify issues. Nothing personal. No third parties.", | |||
| "Sessions": "Sessions", | |||
| "You can use this device to sign in a new device with a QR code. ": "You can use this device to sign in a new device with a QR code. ", | |||
| "There are two ways to do this:": "There are two ways to do this:", | |||
| " You will need to use this device to scan the QR code shown on your other device that’s signed out.": " You will need to use this device to scan the QR code shown on your other device that’s signed out.", | |||
There was a problem hiding this comment.
This one has a space at the start that shouldn't be there
hughns
changed the title
|
FTR, this PR was superseded by #9403 |
This PR currently depends on #9232 being merged. Compare
Checklist
Here's what your changelog entry will look like:
✨ Features