Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC4037: Thread root is not in the thread #4037

Closed
wants to merge 18 commits into from
Closed

MSC4037: Thread root is not in the thread #4037

wants to merge 18 commits into from

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Jul 13, 2023 •
edited
Loading

Rendered

Implementations:

  • Synapse has the behaviour specified in this proposal 1
  • matrix-js-sdk was recently fixed to match the behaviour required by this proposal, as a bug fix for stuck notifications bugs resulting from inconsistency between Synapse and Element Web.

Footnotes

  1. although it is slightly inconsistent in that it rejects receipts for thread roots that claim to be in the thread, but it accepts receipts for reactions/edits to thread roots that claim to be in the thread, although they do not affect the notification count in the thread. ↩

@andybalaam andybalaam marked this pull request as ready for review July 13, 2023 17:16
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jul 13, 2023
@andybalaam andybalaam mentioned this pull request Jul 14, 2023
Open
@andybalaam @jplatte
Fix missing space
b82c829 
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
turt2live
turt2live requested changes Jul 17, 2023
View reviewed changes
proposals/4037-thread-root-is-not-in-thread.md Outdated Show resolved Hide resolved
proposals/4037-thread-root-is-not-in-thread.md Outdated Show resolved Hide resolved
proposals/4037-thread-root-is-not-in-thread.md Outdated Show resolved Hide resolved
proposals/4037-thread-root-is-not-in-thread.md Outdated Show resolved Hide resolved
@turt2live turt2live added the blocked Something needs to be done before action can be taken on this PR/issue. label Jul 18, 2023
turt2live
turt2live reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see contained comment thread

proposals/4037-thread-root-is-not-in-thread.md Show resolved Hide resolved
proposals/4037-thread-root-is-not-in-thread.md Show resolved Hide resolved
@turt2live turt2live removed blocked Something needs to be done before action can be taken on this PR/issue. needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Aug 8, 2023
@andybalaam andybalaam mentioned this pull request Nov 22, 2023
Merged
@andybalaam
Copy link
Member Author

Replaced by spec PR matrix-org/matrix-spec#1677

@andybalaam andybalaam closed this Nov 22, 2023
@turt2live turt2live added the obsolete A proposal which has been overtaken by other proposals label Nov 23, 2023
@andybalaam andybalaam mentioned this pull request Dec 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live requested changes

@jplatte jplatte jplatte left review comments

@clokep clokep clokep left review comments

Assignees

@andybalaam andybalaam

Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec obsolete A proposal which has been overtaken by other proposals proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andybalaam @clokep @jplatte @turt2live