Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4037: Thread root is not in the thread #4037

Closed
wants to merge 18 commits into from
Closed

MSC4037: Thread root is not in the thread #4037

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7257e37
Summary
andybalaam Jul 13, 2023
3a5f56d
First draft
andybalaam Jul 13, 2023
e1f61e8
Small wording improvements
andybalaam Jul 13, 2023
ac05600
Fill in other sections
andybalaam Jul 13, 2023
d9edaa4
Add additional explicit clarification
andybalaam Jul 13, 2023
b82c829
Fix missing space
andybalaam Jul 17, 2023
651824f
Note that reactions to thread roots should be in the main timeline
andybalaam Jul 17, 2023
ccf00d3
Link to a specific version of the spec
andybalaam Jul 18, 2023
62d4f51
Link to Synapse code for deciding what thread an event is in
andybalaam Jul 18, 2023
cb06a85
Explain why reactions to thread roots should be in the main timeline
andybalaam Jul 18, 2023
3421e3e
Add a note about Synapse behaviour for edits of thread roots
andybalaam Jul 18, 2023
14ef925
Be more explicit that reactions/edits/etc to thread roots are in the …
andybalaam Jul 18, 2023
72af2a0
Add missing s
andybalaam Jul 18, 2023
17c9942
Add missing e
andybalaam Jul 18, 2023
f8a857e
Update to our new understanding of Synapse behaviour
andybalaam Jul 18, 2023
7b5fb5b
Clarify that Synapse returns an error
andybalaam Jul 18, 2023
6176516
Add a 'How we got here' section
andybalaam Jul 19, 2023
375e27f
Add more words about children of thread roots
andybalaam Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion proposals/4037-thread-root-is-not-in-thread.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ We propose that thread roots are in the main timeline, making the definition:
> "main timeline": a special thread with an ID of `main`.
>
> Note: thread roots (events that are referred to in a `m.thread` relationship)
> are in the main timeline.
> are in the main timeline. Similarly, reactions to thread roots, edits of
> thread root, and other events with non-thread relations to a thread root are
> in the main timline.
andybalaam marked this conversation as resolved.
Show resolved Hide resolved

## Potential issues

Expand Down