Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Config option to inhibit 3PID errors on /requestTokenBabolivier/dinsic request token #41

Closed
wants to merge 3,138 commits into from

Conversation

babolivier
Copy link
Contributor

Port of matrix-org/synapse#7315

Built on top of #39

* commit '0495097a7':
  Added the section 'Configuration' in /docs/turn-howto.md (#6614)
* commit '6964ea095':
  Reduce the reconnect time when replication fails. (#6617)
* commit 'b6b57ecb4':
  Kill off redundant SynapseRequestFactory (#6619)
* commit '98247c4a0':
  Remove unused, undocumented "content repo" resource (#6628)
…626)

* commit 'e48410130':
  Raise an error if someone tries to use the log_file config option (#6626)
* commit '08815566b':
  Automate generation of the sample and debian log configs (#6627)
…oom upgrade (#6633)

* commit '01c3c6c92':
  Fix power levels being incorrectly set in old and new rooms after a room upgrade (#6633)
* commit '18674eebb':
  Workaround for error when fetching notary's own key (#6620)
* commit '4b36b482e':
  Fix exception when fetching notary server's old keys (#6625)
…dler. (#6640)

* commit 'ab4b4ee6a':
  Fix an error which was thrown by the PresenceHandler _on_shutdown handler. (#6640)
* commit '9f6c1befb':
  Add experimental 'databases' config (#6580)
* commit 'ba897a759':
  Fix some test failures when frozen_dicts are enabled (#6642)
* commit '1807db5e7':
  changelog
  Remove unused get_latest_event_ids_and_hashes_in_room
  Remove unused get_prev_events_and_hashes_for_room
  Remove unused hashes and depths from _update_membership params
  Remove unused hashes and depths from create_event params
  Remove unused hashes and depths from create_new_client_event params
  replace get_prev_events_and_hashes_for_room with get_prev_events_for_room in create_new_client_event
  rename get_prev_events_for_room to get_prev_events_and_hashes_for_room
* commit 'd20c34654':
  port BackgroundUpdateTestCase to HomeserverTestCase (#6653)
  changelog
  Fix exceptions in log when rejected event is replicated
  async/await for SyncReplicationHandler.process_and_notify
  Clarify documentation on get_event* methods
* commit '9824a39d8':
  Async/await for background updates (#6647)
…(#6648)

* commit '85db7f73b':
  Add a background update to clear tombstoned rooms from the directory (#6648)
* commit '0ab5853ec':
  Changelog
  Fix conditions failing if min_depth = 0
* commit '7f0e706eb':
  1.8.0rc1
…typo

* commit '2b6b7f482':
  Reword
  Change the example from 5min to 12h
  Fixup changelog
  Fixup changelog
  Fixup changelog
  Changelog
  Update sample config
  Fix a typo in the purge jobs configuration example
* commit 'be29ed7ad':
  Correctly proxy remote group HTTP errors. (#6654)
… (#6656)

* commit 'dd57715de':
  contrib/docker-compose: fixing mount that overrides containers' /etc (#6656)
  typo
* commit 'cff1cb868':
  Fix reference
  Incorporate review
  Apply suggestions from code review
  Update changelog.d/6624.doc
  Fix vacuum instructions for sqlite
  Rename changelog
  Add a complete documentation of the message retention policies support
* commit '573fee759':
  Back out ill-advised notary server hackery (#6657)
* commit '7caaa29da':
  Fix GET request on /_synapse/admin/v2/users endpoint (#6563)
* commit 'e16521faa':
  Changelog
  Fix typo in message retention policies doc
* commit '7c232bd98':
  Shuffle the code
  Comments
  Do not rely on streaming events, as media repo doesn't
  Newsfile
  Import RoomStore in media worker to fix admin APIs
  Move media admin store functions to worker store
* commit '24b2c940f':
  1.8.0
…#6495)

* commit 'd2906fe66':
  Allow admin users to create or modify users without a shared secret (#6495)
  Fixup changelog
* commit 'c2ba994db':
  Add note about log_file no longer be accepted (#6674)
* commit '1d16f5ea0':
  update install notes for CentOS
  changelog
  Refuse to start if sqlite is older than 3.11.0
  Check postgres version in check_database
  Modify check_database to take a connection rather than a cursor
anoadragon453 and others added 27 commits March 24, 2020 14:24
* commit '1d66dce83':
  Break down monthly active users by appservice_id  (#7030)
* commit '2bff4457d':
  Add type hints to logging/context.py (#6309)
* commit 'bbf725e7d':
  Lint
  Mention the session ID in the error message
  Lint
  Changelog
  Make sure that is_verified is a boolean when processing room keys
* commit '66315d862':
  Update routing of fallback auth in the worker docs. (#7048)
…ental room ver. (#7037)

* commit '06eb5cae0':
  Remove special auth and redaction rules for aliases events in experimental room ver. (#7037)
…push_action_before

* commit '14b2ebe76':
  Changelog
  Fix undefined `room_id` in `make_summary_text`
  Move `get_time_of_last_push_action_before` to the `EventPushActionsWorkerStore`
* commit '6640460d0':
  Rephrase default message
  Hopefully mypy is happy now
  Attempt at appeasing the gods of mypy
  Lint
  Changelog
  Update sample config
  SAML2: render a comprehensible error page if something goes wrong
* commit '6a3504636': (29 commits)
  Revert "Add options to disable setting profile info for prevent changes. (#7053)"
  Populate the room version from state events (#7070)
  Fix buggy condition in account validity handler (#7074)
  Use innerText instead of innerHTML
  Add type annotations and comments to auth handler (#7063)
  Lint
  Put the file in the templates directory
  Update wording and config
  Changelog
  Move the default SAML2 error HTML to a dedicated file
  Refactor a bit
  Also don't fail on aliases events in this case
  Lint
  Changelog
  Also don't filter out events sent by ignored users when checking state visibility
  Fix condition
  Don't filter out dummy events when we're checking the visibility of state
  Update sample_config.yaml
  Update synapse/config/registration.py
  lint, fix tests
  ...
* commit '60724c46b':
  Remove special casing of `m.room.aliases` events (#7034)
* commit '7581d30e9':
  Remove unused federation endpoint (`query_auth`) (#7026)
…es (#7044)

* commit '5e477c1de':
  Set charset to utf-8 when adding headers for certain text content types (#7044)
* commit 'c37db0211':
  Share SSL contexts for non-federation requests (#7094)
* commit '6d110ddea':
  Update INSTALL.md updated CentOS8 install instructions (#6925)
…er devices. (#7085)

* commit '88b41986d':
  Add an option to the set password API to choose whether to logout other devices. (#7085)
* commit '4a17a647a':
  Improve get auth chain difference algorithm. (#7095)
* commit '443162e57':
  Move pusherpool startup into _base.setup (#7104)
* commit '8c75667ad':
  Add prometheus metrics for the number of active pushers (#7103)
* commit 'e913823a2':
  Fix concurrent modification errors in pusher metrics (#7106)
* commit 'e43e78b98':
  1.12.0rc1
  update grafana dashboard
* commit '2fa55c0cc':
  1.12.0
  more changelog
  changelog fixes
  fix typo
…nsic-release-v1.12.x

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
Adds a request_token_inhibit_errors configuration flag (disabled by
default) which, if enabled, change the behaviour of all /requestToken
endpoints so that they return a 200 and a fake sid if the 3PID was/was
not found associated with an account (depending on the endpoint),
instead of an error.

Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surely this should be a merge rather than a cherry-pick? doing a cherry-pick will mean that we have conflicts when we come to do future merges from mainline to dinsic.

@babolivier
Copy link
Contributor Author

Superseded by #42

@babolivier babolivier closed this Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants