Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Docker image downloads and installs rust linting tools #14139

Closed
DMRobertson opened this issue Oct 11, 2022 · 1 comment · Fixed by #14141
Closed

Docker image downloads and installs rust linting tools #14139

DMRobertson opened this issue Oct 11, 2022 · 1 comment · Fixed by #14141
Labels
A-Docker Docker images, or making it easier to run Synapse in a container. A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@DMRobertson
Copy link
Contributor

Noticed in a complement run here.

#14 [builder  4/10] RUN curl -sSf https://sh.rustup.rs/ | sh -s -- -y --no-modify-path --default-toolchain stable
#14 sha256:91538b4a34f809dacd22be60c6689bf685259a453eeda79561cb54eb353de204
#14 0.495 info: downloading installer
#14 1.046 info: profile set to 'default'
#14 1.046 info: default host triple is x86_64-unknown-linux-gnu
#14 1.046 info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
#14 1.194 info: latest update on 2022-09-22, rust version 1.64.0 (a55dd71d5 2022-09-19)
#14 1.194 info: downloading component 'cargo'
#14 1.352 info: downloading component 'clippy'
#14 1.415 info: downloading component 'rust-docs'
#14 1.808 info: downloading component 'rust-std'
#14 2.368 info: downloading component 'rustc'
#14 3.589 info: downloading component 'rustfmt'
#14 3.682 info: installing component 'cargo'
#14 4.447 info: installing component 'clippy'
#14 4.849 info: installing component 'rust-docs'
#14 8.892 info: installing component 'rust-std'
#14 12.13 info: installing component 'rustc'
#14 17.68 info: installing component 'rustfmt'
#14 18.27 info: default toolchain set to 'stable-x86_64-unknown-linux-gnu'

I expect we need cargo, rust-std, rustc, but don't need clippy, rust-docs and rustfmt. Looks like we can shave a few seconds off if there's a way to omit those (particularly: installing docs and maybe rustfmt).

Don't think this will help #13204 since it should only affect initial setup.

@DMRobertson DMRobertson added A-Docker Docker images, or making it easier to run Synapse in a container. S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 11, 2022
@DMRobertson DMRobertson changed the title Docker image downloads rust linting tools Docker image downloads and installs rust linting tools Oct 11, 2022
@DMRobertson DMRobertson added the A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers label Oct 11, 2022
@DMRobertson
Copy link
Contributor Author

Maybe we need to pass --profile minimal to the bootstrap script? See https://github.com/rust-lang/rustup/blob/master/rustup-init.sh#L46 and https://rust-lang.github.io/rustup/concepts/profiles.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Docker Docker images, or making it easier to run Synapse in a container. A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant