This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use minimal Rust installation in docker images and CI #14141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2022 17:11
reivilibre
approved these changes
Oct 12, 2022
|
@DMRobertson Looks like builds have been failing on develop since this was merged. Any idea if it is related or due to the other shenanigans going on? |
|
I think the other shenanigans are to blame. The docker image builds locally for me, and is built by CI as part of the complement job. (If anything, this change should mean we spend less time building arm docker images and so it should make the situation better, not worse.) We should be able to see what happens when #14173 is merged into develop tomorrow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14139
(branch name is wrong, should be
dmr/rust-minimal-profile)Will likely conflict with #14130.