Fix docker build OOMing in CI for arm64 builds

[erikjohnston]

Not sure if we just want to default to true?

[DMRobertson]

do ARGs become environment variables for the directives below them? (otherwise how does this work?!)

[erikjohnston]

Yup, I believe so!

[babolivier]

Good point, it doesn't look like it from a quick local test:

[18:09:36] babolivier@Noah:~/Documents/test$ cat Dockerfile 
FROM alpine
ARG TEST
COPY ./test.sh /test.sh
ENTRYPOINT ["/test.sh"]
[18:10:28] babolivier@Noah:~/Documents/test$ cat test.sh 
#!/bin/sh
env
[18:10:40] babolivier@Noah:~/Documents/test$ docker build -t test -f Dockerfile --build-arg=TEST=foo .
Sending build context to Docker daemon  3.072kB
Step 1/4 : FROM alpine
 ---> 9c6f07244728
Step 2/4 : ARG TEST
 ---> Using cache
 ---> 69700947c516
Step 3/4 : COPY ./test.sh /test.sh
 ---> Using cache
 ---> 2bb37955a594
Step 4/4 : ENTRYPOINT ["/test.sh"]
 ---> Using cache
 ---> 120f3318464d
Successfully built 120f3318464d
Successfully tagged test:latest
[18:12:11] babolivier@Noah:~/Documents/test$ docker run test --build-arg=TEST=foo
HOSTNAME=fce46e554943
SHLVL=1
HOME=/root
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PWD=/
[18:12:17] babolivier@Noah:~/Documents/test$ 

[erikjohnston]

nyargh what

[erikjohnston]

Oh for gods sake, RUN $TEST would do the right thing, but we actually need an ENV TEST=$TEST I think

[DMRobertson]

#26 7.217       cargo rustc --lib --message-format=json-render-diagnostics --manifest-path rust/Cargo.toml --release -v --features pyo3/extension-module -- --crate-type cdylib
  #26 7.217           Updating crates.io index
  #26 7.217       error: Unable to update registry `crates-io`
  #26 7.217       
  #26 7.217       Caused by:
  #26 7.217         failed to fetch `[https://github.com/rust-lang/crates.io-index`](https://github.com/rust-lang/crates.io-index%60)
  #26 7.217       
  #26 7.217       Caused by:
  #26 7.217         error in environment variable `CARGO_NET_GIT_FETCH_WITH_CLI`: provided string was not `true` or `false`

[richvdh]

er, note that ENV defines a variable that will be present in containers started from the final image, which I don't think is really what you want here.

(I guess it won't do any harm, but it does seem like an odd variable for us to export to our image).

Instead you have to do CARGO_NET_GIT_FETCH_WITH_CLI=$CARGO_NET_GIT_FETCH_WITH_CLI before the pip that needs it.

[erikjohnston]

Yeah, though ENV should only affect the current build stage and so not be in the final image.

[richvdh]

ah yes, fair